The Wayback Machine - https://web.archive.org/web/20220303085329/https://github.com/nextcloud/server/pull/31389
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fileactions for sharing overview #31389

Merged
merged 1 commit into from Mar 2, 2022
Merged

fix fileactions for sharing overview #31389

merged 1 commit into from Mar 2, 2022
+4 −3

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 1, 2022 •
edited

Fix #27671

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/27671/fix-sharing-overview-actions \
-e VIEWER_BRANCH=master \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest
@szaimen szaimen added this to the Nextcloud 24 milestone Mar 1, 2022
@szaimen szaimen force-pushed the enh/27671/fix-sharing-overview-actions branch 2 times, most recently from 4e9d212 to 8b0c22e Mar 1, 2022
CarlSchwan
CarlSchwan approved these changes Mar 2, 2022
View changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Tested locally, just need npm run build :)
@szaimen
Copy link
Contributor Author

@szaimen szaimen commented Mar 2, 2022

/compile amend /
@szaimen
Copy link
Contributor Author

@szaimen szaimen commented Mar 2, 2022

Thanks Carl! :)
@szaimen @nextcloud-command
try to fix correct fileactions for sharing overview
1bb2534 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/27671/fix-sharing-overview-actions branch from 8b0c22e to 1bb2534 Mar 2, 2022
@szaimen szaimen marked this pull request as ready for review Mar 2, 2022
@szaimen
Copy link
Contributor Author

@szaimen szaimen commented Mar 2, 2022

/backport to stable23
@szaimen
Copy link
Contributor Author

@szaimen szaimen commented Mar 2, 2022

/backport to stable22
@szaimen szaimen changed the title try to fix correct fileactions for sharing overview fix fileactions for sharing overview Mar 2, 2022
@szaimen szaimen requested review from , PVince81 (assigned from nextcloud/server-frontend), skjnldsv (assigned from nextcloud/server-frontend) and Pytal (assigned from nextcloud/server-frontend) and removed request for Mar 2, 2022
Pytal
Pytal approved these changes Mar 2, 2022
View changes
@szaimen
Copy link
Contributor Author

@szaimen szaimen commented Mar 2, 2022

Failure unrelated, afaics (timeout)
@szaimen szaimen merged commit 0f34bce into master Mar 2, 2022
24 of 25 checks passed
@szaimen szaimen deleted the enh/27671/fix-sharing-overview-actions branch Mar 2, 2022
@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 2, 2022

The backport to stable23 failed. Please do this backport manually.
@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 2, 2022

The backport to stable22 failed. Please do this backport manually.
@szaimen
Copy link
Contributor Author

@szaimen szaimen commented Mar 2, 2022

Okay, i am pretty sure now that the backport bot is broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review backport-request bug
3 participants
@szaimen @CarlSchwan @Pytal