The Wayback Machine - https://web.archive.org/web/20220111231410/https://github.com/graphql/graphiql/issues/2074
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable editor have an infinity scroll when the user wanted to resize it #2074

Open
Zeuhan opened this issue Dec 2, 2021 · 5 comments
Open

Variable editor have an infinity scroll when the user wanted to resize it #2074

Zeuhan opened this issue Dec 2, 2021 · 5 comments
Labels
bug confirmed bug good first issue graphiql

Comments

@Zeuhan
Copy link

@Zeuhan Zeuhan commented Dec 2, 2021 •
edited

Hi Team,

When the user want to resize the variable editor and keep the bar at the top the container starts to increase without any kind of limit so that cause an inside infinite scroll.

Screenshot of the UI after scroll for a few seconds:
image

Screenshot of the amount of pixels that have in height:
image

Edit: I tried to put a max-height with the .CodeMirror-scroll class and I tried to figure out creating a div outside to limit the height but not results.
@acao
Copy link
Member

@acao acao commented Dec 4, 2021 •
edited

I can't reproduce it here yet:
https://graphiql-test.netlify.app/

perhaps you could provide a codesandbox to demonstrate it?
@Zeuhan
Copy link
Author

@Zeuhan Zeuhan commented Dec 13, 2021

Steps to reproduce:

  1. Drag the variables menu to the top and maintain there for a little bit.
  2. You will have an infinite scroll

Video from https://graphiql-test.netlify.app/ :
https://user-images.githubusercontent.com/48504276/145867868-5160131a-f6b7-4f95-ac1b-30d96223d46f.mov
@acao
Copy link
Member

@acao acao commented Dec 13, 2021

thank you!
@acao
Copy link
Member

@acao acao commented Dec 13, 2021

woah! that's a bug alright.
@acao
Copy link
Member

@acao acao commented Dec 13, 2021

it must be a regression that I overlooked when we added the headers editor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug good first issue graphiql
2 participants
@acao @Zeuhan