upgrade Rubocop & drop Ruby 2.4.x support #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnesteryuk
changed the title
dnesteryuk
force-pushed
the
upgrade-deps
branch
2 times, most recently
from
168ee1f
to
ab42954
Compare
To use latest Rubocop we need to drop support for Ruby 2.4.x. Also, this change fixes some offenses with auto correction.
|
Should we bump version to 1.6.0? |
|
Thanks, merged. Btw, please work off a fork, even when you have r/w access ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
To use latest Rubocop we need to drop support for Ruby 2.4.x.
Also, this change fixes some offenses with auto correction.