The Wayback Machine - https://web.archive.org/web/20220310002915/https://github.com/atom/language-css/pull/182
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in @-ms-viewport and @-o-viewport to CSS grammar #182

Merged
merged 2 commits into from Jul 19, 2021

Conversation

jpcastberg
Copy link
Contributor

@jpcastberg jpcastberg commented Jul 15, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Adds support for vendor prefixes -ms- and -o- to the viewport at-rule

Alternate Designs

No alternatives considered, I think I have fixed it appropriately within the architecture.

Benefits

Css grammar support will reflect viewport syntax used in older browsers.

Possible Drawbacks

...none?

Applicable Issues

fixes #176

@jpcastberg
Copy link
Contributor Author

@jpcastberg jpcastberg commented Jul 17, 2021

looking for a maintainer to take a look... @sadick254 ?

Copy link
Contributor

@sadick254 sadick254 left a comment

This looks good. Thank you for contributing.

@sadick254 sadick254 merged commit 8c9b224 into atom:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants