The Wayback Machine - https://web.archive.org/web/20220706070959/https://github.com/TheAlgorithms/Java/pull/2932
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add permutation #2932

Merged
merged 3 commits into from Feb 9, 2022
Merged

add permutation #2932

merged 3 commits into from Feb 9, 2022
+170 −0

Conversation

cpiao3
Copy link
Contributor

@cpiao3 cpiao3 commented Jan 31, 2022 •
edited

Describe your change:

  • [ x] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • [ x] I have read CONTRIBUTING.md.
  • [ x] This pull request is all my own work -- I have not plagiarized.
  • [ x] I know that pull requests will not be merged if they fail the automated tests.
  • [ x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new Java files are placed inside an existing directory.
  • [ x] All filenames are in all uppercase characters with no spaces or dashes.
  • [ x] All functions and variable names follow Java naming conventions.
  • [ x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@cpiao3 cpiao3 requested review from siriak and yanglbme as code owners Jan 31, 2022
@cpiao3
Copy link
Contributor Author

@cpiao3 cpiao3 commented Feb 3, 2022

@siriak can you review this; added combination as well.
@cpiao3
Copy link
Contributor Author

@cpiao3 cpiao3 commented Feb 6, 2022

@siriak added tests and deleted main()
siriak
siriak approved these changes Feb 9, 2022
View changes
Copy link
Member

@siriak siriak left a comment

LGTM, thanks!
@siriak siriak merged commit 12c67bc into TheAlgorithms:master Feb 9, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@cpiao3 @siriak