mozilla

Based on the designs there should be a 17dp space between Pocket stories/categories headers and their content.

Th

I wrote this as a hack to set the SDK_INT in tests, but its properly supported using the @Config(sdk = [Build.VERSION_CODES.X]) annotation. The function should be replaced with the annotation and removed.

This issue was created automatically by a script.

Bug 1703773

Bug Reporter: @flodolo
CC: @mathjazz

Currently sync runs following the alphabetical order of language names, not locale codes. That's not intuitive, and makes debugging sync issues harder.

In URLExtensions.swift we have isIPv4 and isIPv6 functions. The first uses a regex and the second just checks for the presence of a : in the string. Let's replace this with a call to inet_pton() to let the OS parse the address instead - delegating to a trusted OS function will be more robust.

Example at https://stackoverflow.com/questions/35056268/how-to-use-swift-convert-string-to-ip