The Wayback Machine - https://web.archive.org/web/20220409083028/https://github.com/jcubic/jquery.terminal/issues/684
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all licenses and copyright notes for used code #684

Open
jcubic opened this issue Aug 23, 2021 · 7 comments
Open

Add all licenses and copyright notes for used code #684

jcubic opened this issue Aug 23, 2021 · 7 comments

Comments

@jcubic
Copy link
Owner

@jcubic jcubic commented Aug 23, 2021

I have an idea for a new feature for jQuery Terminal

I think that to be correct the LICENSE file should include copyright notes from all projects that are included. And a copy of all licenses is inside that file.

All libraries from at the beginning of the jquery.terminal-src.js file should be looked up and their licenses should be included in this project LICENSE file.

@Vyvy-vi
Copy link

@Vyvy-vi Vyvy-vi commented Jan 29, 2022

from what I understand, the LICENSE file is supposed to be your license with your copyright header (if you're not directly using anything GPL and any code being used isn't superseding the MIT License). The copyright headers need to remain inside the code that you reproduced from that project in yours.

what you need to make is a secondary file called LICENSE_third_party.txt (or something similar) that contains all the license text from those libraries. (like https://raw.githubusercontent.com/gitpod-io/gitpod/main/License.third-party.npm.txt)

@jcubic
Copy link
Owner Author

@jcubic jcubic commented Jan 29, 2022

@Vyvy-vi I'm almost sure that I've seen a single LICENSE file with all licenses for code that was included in the project. I've thought that it was Gambit or Kawa, but they don't have such a file. I'm not sure what other big project could have something like this.

@jcubic
Copy link
Owner Author

@jcubic jcubic commented Jan 29, 2022

@Vyvy-vi found this question on StackExchange How to combine multiple LICENSE notes into single file?, the answer says:

One common pattern is to concatenate the different LICENSE in your own LICENSE file

@Vyvy-vi
Copy link

@Vyvy-vi Vyvy-vi commented Jan 29, 2022

that's an approach, however, doesn't that ambiguously imply to people using your application that they and you would also be subject to terms in the licenses of the libraries that you're using? (while most of the code you're using is under MIT, and thus doesn't really need you to include a license(only retaining the copyright headers put in there by authors) for them and doesn't conflict with your licenses, but in cases where someone was using something like Apache it might cause confusion because Apache has some different terms than MIT.)

@Vyvy-vi
Copy link

@Vyvy-vi Vyvy-vi commented Jan 29, 2022

*in cases where a large share of the project directly uses someone else's code, modifies it and re-distributes it (derivative work) you'd need to share the copyright headers in your MIT License, and mention what's used from their project. eg:

Copyright (c) 2016 [XYZ], author of [project] modified in [your-project]
Copyright (c) 2011-2021 Jakub Jankiewicz
@jcubic
Copy link
Owner Author

@jcubic jcubic commented Jan 29, 2022

This is what I've used in my other project https://github.com/jcubic/lips/blob/master/LICENSE
I've included all licenses intact even though they are the same MIT license.

@Vyvy-vi
Copy link

@Vyvy-vi Vyvy-vi commented Jan 29, 2022

Well, then I guess that's the way to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants