The Wayback Machine - https://web.archive.org/web/20220224163542/https://github.com/ChainSafe/web3.js/pull/4701
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e_gnosis_dex mute #4701

Merged
merged 5 commits into from Jan 18, 2022
Merged

e2e_gnosis_dex mute #4701

merged 5 commits into from Jan 18, 2022

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jan 13, 2022

Description

As discussed e2e gnosis test in CI is being muted in this PR, until fixed.
#4436

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
@render
Copy link

@render render bot commented Jan 13, 2022

Your Render PR Server URL is https://web3-js-pr-4701.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7g3n2c6fj3ffl60naq0.
@coveralls
Copy link

@coveralls coveralls commented Jan 13, 2022 •
edited

Pull Request Test Coverage Report for Build 1712441871

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 265 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 75.036%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 7 85.42%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 44 9.66%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 1708921647: 2.3%
Covered Lines: 3253
Relevant Lines: 4101
💛 - Coveralls
@luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jan 14, 2022

i think it would be good to create a note about why we are doing this, either as a comment in build.yml we are disabling it and adding it to changelog
nazarhussain
nazarhussain reviewed Jan 18, 2022
View changes
CHANGELOG.md Outdated Show resolved Hide resolved
nazarhussain
nazarhussain reviewed Jan 18, 2022
View changes
scripts/ci.sh
#elif [ "$TEST" = "e2e_gnosis_dex" ]; then
#
# npm run test:e2e:publish
# npm run test:e2e:gnosis:dex
#
Copy link
Contributor

@nazarhussain nazarhussain Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to comment these, as it will not be executed by CI server anyway.
@jdevcs jdevcs merged commit 1308c3c into 1.x Jan 18, 2022
16 checks passed
@jdevcs jdevcs deleted the junaid/e2e_gnosis_dex4436 branch Jan 18, 2022
@jdevcs jdevcs mentioned this pull request Feb 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@jdevcs @coveralls @luu-alex @nazarhussain