The Wayback Machine - https://web.archive.org/web/20220409035606/https://github.com/dailydotdev/daily/issues/297
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content guidelines link in the request source popup #297

Open
idoshamun opened this issue Jun 21, 2021 · 16 comments · May be fixed by dailydotdev/apps#946
Open

Add content guidelines link in the request source popup #297

idoshamun opened this issue Jun 21, 2021 · 16 comments · May be fixed by dailydotdev/apps#946

Comments

@idoshamun
Copy link
Member

@idoshamun idoshamun commented Jun 21, 2021

We want to add a link to our content guidelines before a user submits a source request. This will provide users a better understanding of what the process is and what content we allow, and what not.

feature design

How to get started?

Sketch Cloud project is available here with all the nitty-gritty 👇
https://www.sketch.com/s/2549ccf9-b98c-413f-96fb-81b05b59e65f/a/9PZRRDp

@killshot13
Copy link

@killshot13 killshot13 commented Jun 23, 2021

It doesn't look like anyone has begun working on this one yet, so I'll go ahead and start working on implementation. 👍

@idoshamun
Copy link
Member Author

@idoshamun idoshamun commented Jun 23, 2021

@killshot13 perfect! Thank you :)
I just updated the local environment docs as they were a bit out of date.
Let me know if you need any guidance.
Good luck 🤘

@killshot13
Copy link

@killshot13 killshot13 commented Jul 10, 2021

Is there any way to either bypass or authorize the sign-in to Google/GitHub in the dev environment? This is probably a noob question, but I also don't want to go down the rabbit hole if there is a simple workaround... @idoshamun?

Because when I am trying to view/test my changes to the code using the hot extension reload, it won't let me "suggest" a new RSS feed without signing in. 😐

2021-07-10_072113_Trim.mp4

Thank you!!!

@idoshamun
Copy link
Member Author

@idoshamun idoshamun commented Jul 11, 2021

Hey @killshot13,

You can disable the authentication check in the relevant callback. See the below to the specific line:
https://github.com/dailydotdev/apps/blob/master/packages/shared/src/components/filters/SourcesFilter.tsx#L96

Let me know if I can assist further.

@lifez
Copy link

@lifez lifez commented Aug 14, 2021

@killshot13 Are you still working on this issue. Can I work on this?

@killshot13
Copy link

@killshot13 killshot13 commented Aug 14, 2021

I am but you are welcome to help. I have been busier than expected so I've been a bit slower than usual.

@idoshamun
Copy link
Member Author

@idoshamun idoshamun commented Aug 17, 2021

@lifez you can go ahead and work on it :)
Let me know if you need any help

@umairhm
Copy link

@umairhm umairhm commented Nov 17, 2021

@idoshamun I was trying to set up the dev environment locally in the hope to fix this thing, but I couldn't get the Postgres DB to work. I see the following error in the Docker logs:

Screen Shot 2021-11-17 at 2 06 53 AM

@idoshamun
Copy link
Member Author

@idoshamun idoshamun commented Nov 17, 2021

@umairhm that's a weird exception. Can you try pulling the latest changes of this repo? We changed a bit the docker-compose file. If it doesn't help, I'll try to look for a solution

@umairhm
Copy link

@umairhm umairhm commented Nov 17, 2021

@idoshamun I pulled the latest master, but still the same error. Not sure if I am missing something locally or it's the image that's broken.

@idoshamun
Copy link
Member Author

@idoshamun idoshamun commented Nov 17, 2021

Can you please try to run:

docker-compose down
docker-compose rm -v

And then try again. Stack Overflow says that it's probably due to existing data

@ankitverma2211
Copy link

@ankitverma2211 ankitverma2211 commented Jan 12, 2022

hey, @idoshamun is this actively being worked on. If shall I try to tackle it .

@umairhm
Copy link

@umairhm umairhm commented Jan 12, 2022

Hey @ankitverma2211, I was trying work on this but for some weird reason, I couldn't set up the environment. And now I'm swamped with work, so I'm not able to make time right now.

Please take it away and best of luck 😊

@idoshamun
Copy link
Member Author

@idoshamun idoshamun commented Jan 13, 2022

@ankitverma2211 sure go ahead! :)
We're here if you need any help

@ankitverma2211
Copy link

@ankitverma2211 ankitverma2211 commented Jan 13, 2022

@idoshamun Thanks for the kind words. Let me try to do the setup

@jonatan5524
Copy link

@jonatan5524 jonatan5524 commented Apr 8, 2022

Hey, I have opened PR related on this issue, I would like someone to review this.
dailydotdev/apps#946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment