disassembler

Environment

Sat Dec 11 06:20:24 AM UTC 2021
rasm2 5.5.2 27280 @ linux-x86-64 git.5.5.2
commit: e65e385e5308293c23611e16e531df8c52a9ff18 build: 2021-12-11__06:31:42
Linux x86_64

Description

The opcodes jecxz and jrcxz cannot assemble.

Test

$ rasm2 -a x86 -b 64 'jecxz 0x1'
Cannot assemble 'jecxz 0x1' at line 3
invalid
$ rasm2 -a x86 -b 64 'jrcxz 0x1

Tl;dr: Use the workaround from https://github.com/pwndbg/pwndbg/pull/322/files only for broken gdb versions

Essentially introduce const where appropriate for the public types exposed by the api.

This request intentionally only targets some functions since we don't have stable &mut in const contexts along with a bunch of other const stuff that is still nightly.

I don't expect that iced will ever become 100% const, that's unreasonable to assume due to the fact iced needs liballoc around the crate.

pdgsd does not seem to process PUSH EBP very well, the p-code semantics show up as

    (unique,0x12f0,4) = COPY EBP
    ESP = INT_SUB ESP, 0x4
    (unique,0x12f0,4) = STORE ram[ESP]

which doesn't make sense. Last line should be STORE ram[ESP] = (unique,0x12f0,4)

the raw p-code will show you:

STORE (const,0x55fef11636d0,8) (register,ESP,4) (unique,0x1b50,4)

and the

We should create a corpus of tests to verify that CFG recovery is accurate and complete, and there are no regressions.