chore(*) support dev container #8265
Conversation
|
Running well on my Mac M1 with VSCode containers. |
tested - works.
Are the whitespace changes in the DEVELOPER.md file intended? If so this should maybe go into a separate PR(or commit)
| @@ -0,0 +1,9 @@ | |||
| FROM kong/kong:2.7.0 | |||
There was a problem hiding this comment.
since the purpose of the dev container is to work on the actual source, shouldn't we maybe use a plain alpine image to avoid conflicts?
There was a problem hiding this comment.
Using a plain alpine or ubuntu image spends more time compiling the dependencies.
We have the postCreateCommand option which will be executed in the initial phase of the new container, it will overwrite Kong's LuaRocks packages.
kong/.devcontainer/devcontainer.json
Line 19 in 27d1014
Gojira also use this method as an option to start a dev environment: gojira up --image kong:2.7.0, see: https://github.com/Kong/gojira/blob/master/docs/manual.md#using-kong-release-images-with-gojira
Other popular projects like dapr also use an existing docker image to start:
https://github.com/dapr/dapr/blob/10784ac6e5886fb4242eac73c4f13a8962d17043/.devcontainer/devcontainer.json#L4
There was a problem hiding this comment.
ye, I saw that. I'm just mildly concerned that stray artifacts have an impact on the sources.
gojira, when used without the --image flag, it also uses a plain ubuntu image. https://github.com/Kong/gojira/blob/master/docker/Dockerfile#L1
Either way, if you don't think my concerns are valid, I'll remain silent and approve this PR :)
Okay, the whitespace changes can be placed in a new PR. |
This reverts commit 7eb2b28.
Summary
Add
devcontainer.jsonto support Visual Studio Code Remote - Containers and GitHub Codespaces.ref: https://code.visualstudio.com/docs/remote/containers
Tested locally.
To test: https://code.visualstudio.com/docs/remote/containers#_quick-start-try-a-development-container
The text was updated successfully, but these errors were encountered: