arduino / arduino-cli Public

…ry/montior (#1636)

* Fixed wrong "event" fields in pluggable monitor specs

* Better specify discoveryDependencies and monitorDependencies fields in package_index.json

…s and monitors (#1633)

* Allow case-insensitive 'ok'/'OK' replies from discoveries and monitors

* Factor the same messages to reduce translations strings

* Better error messages for discoveries and monitor

…it (#1629)

* Factored property composition in convertUploadToolsToPluggableDiscovery

* Auto-generated properties are cached and added after cycling on the original map

* Autogenerated upload tool properties are searched in sub-configs too

Fix #1444

* Added STMicroelectronics:stm32:Nucleo_32:pnum=NUCLEO_F031K6 to upload mock tests

* Use composed board properties to detect user fields

Some platforms may add information through the optional config part of
the FQBN (platforms menu items).

* legacy: refactored ErrorfWithLogger function

Now is no longer needed, this function was basically made for
arduino-builder to allow transfering the error to the IDE, BTW the
correct fix must be made inside arduino-builder (to actually let him
push the error in the logger).

* Renamed legacy ctx fields ExecStdout/ExecStderr to Stdout/Stderr

* Removed empty Lint() function

* Removed dependency on i18n.Logger

* Removed no more used i18n.Logger \o/ \o/

* Simplified i18n.Init function

* legacy: builder default output on os.Stdout/os.Stderr

* legacy: updated integration tests for slightly different output of builder

* Use positional parameter for most translated string

This will make easier to transfer translations from the Arduino IDE 1.8

* Added note to UPGRADING.md

* Updated UPGRADING.md

* Removed extra blank line in library detection recap

* Update docs/UPGRADING.md

Co-authored-by: per1234 <[email protected]>

Previously we checked the recipe for the {serial.port} key to determine
if the upload requires a serial port, but this is not sufficient because
we must check also for the {serial.port.file} key.

* LoggerToCustomStreams must have pointer receiver

Becuase it has a mutex field that otherwise is copied.

* Removed barely used legacy i18n.Logger.UnformattedFprintln function

* Removed barely used legacy i18n.Logger.UnformattedWrite function

* Removed unused AccumulatorLogger

* Added 'percent' to TaskProgress gRPC message

* Added gRPC placeholders to report compile progress

* legacy: builder task progress is now transferred via TaskProgress callback

* Removed unused Logger.Flush interface method

* Removed Logger.Name method (use type-assertions instead)

* Added note on breaking API change

…ms (#1606)

This is mostly useful for "arduino-builder".

)

* Added 'board_platform' and 'build_platform' fields in gRPC Compile command

* Report board platform and build platform on compile output

…1574)

* [breaking] remove `parseArch` var since it is always true

* [breaking] make packages and platform case insensitive
using the `core.GetPlatform()` approach

* enhance comments and do not optimize if results are != 1

* add logging

* add simple test, install, uninstall etc are already covered since they use the same piece of logic (`ParseReference()`)

* Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

* add new error to handle multiple platform found, return res if the string the user is trying to operate matches perfectly one of the available platforms, optimize the code

* enhance comment describing what the function does

* add test to verify that an operation on two fake cores is not possible

* skip test failing on macOS and on win and optimize the test

Co-authored-by: per1234 <[email protected]>

Fix #1562

The installation script checks for an existing installation in the PATH in order to provide appropriate advice to the
user about adding the installation to their their PATH environment variable.

This check is done using `command -v`. It turns out that the exit status is shell dependent in the event the command is
not found, so that it might be either 1 or 127 depending on the user's system. The script previously assumed that the
exit status would be 1 when the command was not found in PATH, which resulted in spurious advice under these conditions:

```
An existing arduino-cli was found at . Please prepend "/home/foo/arduino-cli/bin" to your $PATH or remove the existing one.
```

It seems safest to fix this by inverting the logic so that the advice about an existing installation in PATH is only
printed when one was found.

…-action` (#1602)

The `carlosperate/download-file-action` action is used in the GitHub Actions workflows as a convenient way to download
external resources.

A major version ref has been added to that repository. It will always point to the latest release of the "1" major
version series. This means it is no longer necessary to do a full pin of the action version in use as before.

Use of the major version ref will cause the workflow to use a stable version of the action, while also benefiting from
ongoing development to the action up until such time as a new major release of an action is made. At that time we would
need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major
release before manually updating the major ref (e.g., uses: `carlosperate/download-file-action@v2`). I think this
approach strikes the right balance between stability and maintainability for these workflows.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…)" (#1582)

This reverts commit 55ad9ec.

i18n:check task used to verify only if the source en.po file was up to
date. The new process instead verifies that all translations are up to
date by downloading them directly from Transifex.

The previous process was causing some issues since after uploading the
en.po file Transifex would change its formatting, meaning when calling
i18n:pull we would download a file containing the same information but
formatted in a different way and that made the i18n:check command fail.

By making the i18n:check task call i18n:pull instead of i18n:update we
don't have issues with the formatting anymore.

This change also covers a corner-case that would occur when the
en.po file wasn't updated since a long time, the i18n:check wouldn't
fail because the en.po was the same as before but that wouldn't mean
that the translations were up to date with the latest from Transifex.

* pin task version to verify if can recognize correctly the PATH on win

* pin task version in workflows running on windows

* Updated translation files

* Updated translation files

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Umberto Baldi <[email protected]>

…1569)

* Updated translation files

* Updated translation files

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: umbynos <[email protected]>

…database` (#1552)

* Compilation database: Do not give-up if prototype generation fails

* Added tests

* Compilation database: Do not give up after failing detection of libraries

* Updated translation files

* fix translations

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Umberto Baldi <[email protected]>

…#1558)

* fix a regression introduced in be5022e. `--input` flags were ignored
partially revert "refactor sketch path calculation" in `upload.go`

* fix test after f85513c

* use `WarnDeprecatedFiles` to remove some code duplication

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[breaking] uniform cli commands and flag