The Wayback Machine - https://web.archive.org/web/20201018080508/https://github.com/bevacqua/rome/pull/172
Skip to content

/ rome

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow calendar to work with any numerals #172

Open
wants to merge 1 commit into
base: master
from
Open

Allow calendar to work with any numerals #172

wants to merge 1 commit into from

Conversation

@cttibbetts
Copy link

@cttibbetts cttibbetts commented Aug 24, 2016 •
edited

Because of the use of the text string and parseInt() to get the date value from the calendar, rome was breaking when localized to a system that does not use western-arabic numerals [0, 1, 2, 3...].

By adding the moment.date() value to a custom attributes tag, data-date, we can be sure that the value returned will always be the correct date value.
@cttibbetts
use html attribute to store date value instead of relying on string
d34117c
@cttibbetts cttibbetts mentioned this pull request Aug 15, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@cttibbetts
You can’t perform that action at this time.