The Wayback Machine - https://web.archive.org/web/20211228072758/https://github.com/quasarframework/quasar/issues/8572
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Typescript for Electron, PWA, SSR (?) and quasar.conf #8572

Open
IlCallo opened this issue Mar 4, 2021 · 3 comments
Open

Support Typescript for Electron, PWA, SSR (?) and quasar.conf #8572

IlCallo opened this issue Mar 4, 2021 · 3 comments
Assignees
@IlCallo
Labels
feature request Good first issue typescript

Comments

@IlCallo
Copy link
Member

@IlCallo IlCallo commented Mar 4, 2021 •
edited

Is your feature request related to a problem? Please describe.
Currently Quasar Modes support TS files (for Electron and PWA modes), but the CLI isn't generating them out of the box.

Additional context
We need to create the TS version of all current files in these folders:

This should be a pretty easy task, if anyone wants to jump in, please do!
We'll then manage the integration ourselves

Then I think a --format=ts option already exists for store creation, we could use that when applying the templates, or auto-detecting the presence of tsconfig.json file and act accordingly

Check here to see which has been already ported: #8572 (comment)
@IlCallo IlCallo self-assigned this Mar 4, 2021
@faxinwang
Copy link

@faxinwang faxinwang commented Mar 4, 2021

So we need to extend or chain the webpack configuration in the quasar.conf.js by ourself in order to supported typescript in electron, right?
@faxinwang faxinwang mentioned this issue Mar 4, 2021
Open
3 tasks
@IlCallo
Copy link
Member Author

@IlCallo IlCallo commented Mar 4, 2021

@faxinwang
If we are talking about Quasar v2, AFAIK you just need to change the files extension
https://next.quasar.dev/quasar-cli/developing-electron-apps/electron-with-typescript

Thanks for the contribution! I left some comments on it
@IlCallo
Copy link
Member Author

@IlCallo IlCallo commented Mar 19, 2021 •
edited

Adding references here to avoid redundant work:

  • SSR Qv1 (untested): #8646
  • Electron Qv1 (untested): #8647
  • Electron Qv2 (tested): #8661
  • PWA Qv2 (still unfinished, breaks on build): #8705
@DarkLite1 DarkLite1 mentioned this issue Mar 19, 2021
Open
15 tasks
@IlCallo IlCallo mentioned this issue Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Good first issue typescript
2 participants
@IlCallo @faxinwang