The Wayback Machine - https://web.archive.org/web/20201108125912/https://github.com/google/closure-compiler/issues/3639
Skip to content

/ closure-compiler

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser error on "combining character" (U+0307) #3639

Open
skatsman opened this issue Jul 14, 2020 · 2 comments · May be fixed by #3647
Open

Parser error on "combining character" (U+0307) #3639

skatsman opened this issue Jul 14, 2020 · 2 comments · May be fixed by #3647
Labels
P3 good first issue help wanted

Comments

@skatsman
Copy link

@skatsman skatsman commented Jul 14, 2020

There seems to be an issue with parsing composite character sequences.

Composite character İ consist of the base character and combining character sequence (U+0049)(U+0307)
Using this character causing the compiler to fail with the parser error.

Example code

var bar = {
İ: "foo"
};

Compiler error

input0:2: ERROR - [JSC_PARSE_ERROR] Parse error. Character '̇' (U+0307) is not a valid identifier start char
  2| İ: "foo"
      ^

1 error(s), 0 warning(s)

Demo

Example
@rrdelaney
Copy link
Member

@rrdelaney rrdelaney commented Jul 14, 2020

Is this a blocking error for you?
@skatsman
Copy link
Author

@skatsman skatsman commented Jul 15, 2020

This prevents compiling one of the dependencies (lower-case) of graphql-tools which we use in our project
ctjlewis added a commit to ctjlewis/closure-compiler that referenced this issue Jul 19, 2020
@ctjlewis
Added support for UnicodeCombiningMark, fixes google#3639.
Loading status checks…
5ad0744
This was referenced Jul 19, 2020
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 good first issue help wanted
2 participants
@skatsman @rrdelaney
You can’t perform that action at this time.