The Wayback Machine - https://web.archive.org/web/20211003231328/https://github.com/knative/serving/issues/11785
Skip to content

/ serving Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for configurable PodSpec fields #11785

Open
mattmoor opened this issue Aug 5, 2021 · 3 comments
Open

Improve error message for configurable PodSpec fields #11785

mattmoor opened this issue Aug 5, 2021 · 3 comments
Assignees
@charles-woshicai
Labels
area/API good first issue kind/feature

Comments

@mattmoor
Copy link
Member

@mattmoor mattmoor commented Aug 5, 2021

/area API
/kind good-first-issue

Describe the feature

For flagged fields like kubernetes.podspec-fieldref the validation should include the name of the feature flag to toggle in the error message it surfaces. The validation logic is roughly here:

serving/pkg/apis/serving/k8s_validation.go

Line 246 in 6447982

return apis.CheckDisallowedFields(*source, *EnvVarSourceMask(source, features.PodSpecFieldRef != config.Disabled))

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Aug 5, 2021

@mattmoor: The label(s) kind/good-first-issue cannot be applied, because the repository doesn't have them.

In response to this:

/area API
/kind good-first-issue

Describe the feature

For flagged fields like kubernetes.podspec-fieldref the validation should include the name of the feature flag to toggle in the error message it surfaces. The validation logic is roughly here:

serving/pkg/apis/serving/k8s_validation.go

Line 246 in 6447982

return apis.CheckDisallowedFields(*source, *EnvVarSourceMask(source, features.PodSpecFieldRef != config.Disabled))

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@charles-woshicai
Copy link

@charles-woshicai charles-woshicai commented Aug 20, 2021

/assign
@BLasan
Copy link

@BLasan BLasan commented Sep 14, 2021 •
edited

@charles-woshicai Are you still working on this? I would like to open a PR if not @mattmoor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API good first issue kind/feature
5 participants
@dprotaso @mattmoor @charles-woshicai @knative-prow-robot @BLasan