TheAlgorithms / Python Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mypy] Need help to fix all mypy
errors in the codebase
#4052
Comments
@dhruvmanila I am beginner programmer in python. Is there any help I can do regarding this? |
wrking |
Update:With the latest update for |
I updated the list above to reflect the directories that pass in our build GitHub Action. As contributors fix directories, please add them to the mypy tests in |
…dimensional.py" (TheAlgorithms#4216) Related Issue: TheAlgorithms#4052
Going directory by directory now: 3 additional directories done. Back into timeout, because the next PR will make the bot angry ;) I'm personally aiming for |
+ Prefer tuple to list for point x,y pairs
+ Prefer tuple to list for point x,y pairs
+ Prefer tuple to list for point x,y pairs
* [mypy] Fixes type annotations in other/graham_scan #4052 + Prefer tuple to list for point x,y pairs * NOP: fixes typo in comment
Let's see what is required to finish #4052
In line with issue TheAlgorithms#4052.
* [mypy] Fix type annotation in euler_method.py In line with issue #4052. * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
UPDATE: Our GitHub Actions now run
mypy --ignore-missing-imports
excluding those directories that fail that test.Currently, we are not running
mypy
in our regular CI tests as there are a lot of errors in the entire codebase, which needs to be fixed. This won't be a one-person job, so we are asking for help from you. I cannot paste the entire message in here as there are around 600 of them, so here's just a gist of it:Guidelines to follow:
mypy
in our CI tests, the user who is submitting a pull request should run it on their local machine and ensure there are no errors in their submission.mypy
in it. If possible use this template for your pull request title:Which errors to fix?
Please follow the below steps to produce all the errors in this library:
Then you need to install all the necessary requirements:
Then run either of the two commands:
mypy --ignore-missing-imports .
-> To produce all the error messages for the entire codebase.mypy --ignore-missing-imports <filepath1> <filepath2> ...
-> To produce error messages for the mentioned file.How to fix the errors?
Focus on one directory at a time:
Pre-requisites:
mypy
: https://mypy.readthedocs.ioThe text was updated successfully, but these errors were encountered: