The Wayback Machine - https://web.archive.org/web/20211029142115/https://github.com/TheAlgorithms/Python/pull/4897
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of Coulomb's Law #4897

Merged
merged 1 commit into from Oct 22, 2021
Merged

Add implementation of Coulomb's Law #4897

merged 1 commit into from Oct 22, 2021

Conversation

Labels
None yet
2 participants
@ovynnej @poyea
@ovynnej
Copy link
Contributor

@ovynnej ovynnej commented Oct 2, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}. (Not applicable to this PR.)
@ovynnej
Add implementation of Coulomb's Law
ace1fcc
@ovynnej
Copy link
Contributor Author

@ovynnej ovynnej commented Oct 2, 2021 •
edited

I modeled this implementation of Coulomb's Law on this project's preexisting implementation of Ohm's Law written by @erdum with workshopping by @cclauss.

Thanks in advance for the review! And sorry, I submitted another identical PR a few minutes ago but I decided to close it because there were some problems when I tried to make a followup commit and PR. I hope that simply closing that PR and creating this PR is less of a bother for folks than it would have been to help me troubleshoot that -- I know maintainers have a lot on their plates for Hacktober!
poyea
poyea approved these changes Oct 22, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩
@poyea poyea merged commit 57a7e57 into TheAlgorithms:master Oct 22, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment