The Wayback Machine - https://web.archive.org/web/20220111005548/https://github.com/home-assistant/core/pull/63862
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated async_get_scanner from netgear #63862

Merged
merged 2 commits into from Jan 10, 2022

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented Jan 10, 2022

Breaking change

Your Netgear device tracker has been imported into the UI, please remove it from configuration.yaml.

Proposed change

As follow-up to #54479

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

@probot-home-assistant probot-home-assistant bot commented Jan 10, 2022

Hey there @hacf-fr, @Quentame, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Jan 10, 2022
@epenet epenet marked this pull request as ready for review Jan 10, 2022
@epenet epenet requested a review from Quentame as a code owner Jan 10, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Thanks!

Dev automation moved this from Needs review to Reviewer approved Jan 10, 2022
@MartinHjelmare MartinHjelmare merged commit f24b350 into home-assistant:dev Jan 10, 2022
21 checks passed
Dev automation moved this from Reviewer approved to Done Jan 10, 2022
@@ -44,25 +45,6 @@
)
Copy link
Member

@MartinHjelmare MartinHjelmare Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this. We can remove the platform schema too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment