The Wayback Machine - https://web.archive.org/web/20220329061230/https://github.com/fyne-io/fyne/issues/2306
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to disable ToolbarActions #2306

Open
EugeneSindambiwe opened this issue Jul 1, 2021 · 5 comments
Open

Add the ability to disable ToolbarActions #2306

EugeneSindambiwe opened this issue Jul 1, 2021 · 5 comments
Labels
enhancement good first issue Hacktoberfest
Milestone
Bowmore Release (...

Comments

@EugeneSindambiwe
Copy link

@EugeneSindambiwe EugeneSindambiwe commented Jul 1, 2021

ToolbarActions and MenuItems needs to be disableable for the similar reasons and coherence with DisableableWidgets. Last corresponds to solved #234 .
@Jacalz Jacalz changed the title Add the ability to disable ToolbarActions & MenuItems (see also solved issue #234) Add the ability to disable ToolbarActions & MenuItems Jul 2, 2021
@Jacalz
Copy link
Member

@Jacalz Jacalz commented Jul 2, 2021

Hi. Please use the issue templates when opening issues (the Feature Request template in this case). It makes makes it much easier for us to understand and categorise new issues.

As for this issue, I think it might, at least partially, be a duplicate of #682 when it comes to disabling menus. However, toolbars does not. I think it might be good to transition this to instead be for that part only.
@Jacalz Jacalz added the enhancement label Jul 2, 2021
@andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Jul 4, 2021 •
edited

I think it might be good to transition this to instead be for that part only.

Agreed. Disablable menus are already on PR #2261 heading to the 2.1 release.
Disabling ToolbarAction is a nice addition idea :).
@andydotxyz andydotxyz added this to the Aberlour (2.1) milestone Jul 4, 2021
@EugeneSindambiwe
Copy link
Author

@EugeneSindambiwe EugeneSindambiwe commented Jul 5, 2021

Excellent. Thanks a lot for the responsiveness and positive feedback.
@andydotxyz andydotxyz changed the title Add the ability to disable ToolbarActions & MenuItems Add the ability to disable ToolbarActions Jul 6, 2021
@andydotxyz andydotxyz added the good first issue label Jul 8, 2021
@andydotxyz andydotxyz removed this from the Aberlour (2.1) milestone Sep 12, 2021
@thevibhu
Copy link

@thevibhu thevibhu commented Oct 2, 2021

Can I take up this issue?
@Jacalz
Copy link
Member

@Jacalz Jacalz commented Oct 2, 2021

Absolutely. I don't think anyone has started working on this. Go ahead :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Hacktoberfest
4 participants
@andydotxyz @EugeneSindambiwe @thevibhu @Jacalz