The Wayback Machine - https://web.archive.org/web/20211128215706/https://github.com/kyleneideck/BackgroundMusic/issues/460
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the license that GitHub shows #460

Open
kyleneideck opened this issue Mar 24, 2021 · 3 comments
Open

Fix the license that GitHub shows #460

kyleneideck opened this issue Mar 24, 2021 · 3 comments

Comments

@kyleneideck
Copy link
Owner

@kyleneideck kyleneideck commented Mar 24, 2021

The LICENSE file is a symlink, so GitHub can't figure out what Background Music's license and just shows "view license" on the front page. When you click it, you just see the contents of the symlink file ("IntxLNK�BGMApp/BGMApp/LICENSE").

Also, this makes some sites list the license as "other": https://awesomeopensource.com/project/kyleneideck/BackgroundMusic

@kyleneideck
Copy link
Owner Author

@kyleneideck kyleneideck commented Mar 31, 2021

Just duplicating the LICENSE file is probably a good enough fix for this. That is, replacing the symlink with a copy of the file.

@nodeful
Copy link

@nodeful nodeful commented May 21, 2021

Hey Kyle,
We have spoken before, I've based eqMac's driver on your BGMDriver source code.
Does the GPLv2 License apply to the driver as well? Currently the LICENSE file lives in the BGMApp folder, which led me to believe it only applies to the App itself, not the driver.
I am planning to release some paid features to eqMac very soon to support the development and would like to know how do you see the licensing work with this.
The paid features will be on a private form of the OS repo, so closed source, although any changes to the Driver I would still publish to the OS repo.
Maybe we need to take this conversation offline, I have your WhatsApp from years ago. Let me know :) Awesome work as always btw

@kyleneideck
Copy link
Owner Author

@kyleneideck kyleneideck commented May 24, 2021

@nodeful Yeah, the whole thing is GPLv2 (or any later version). But I think you'd be allowed to "aggregate" a GPL driver with your proprietary version of eqMac as long as you release the driver under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0-faq.en.html#MereAggregation. So it sounds like that's probably fine.

That said, and this doesn't have anything to do with Background Music, but the other contributors to eqMac would still hold the copyright for the code they contributed, unless they assigned it to you or signed a CLA. So if any of that code would be in the proprietary app, you'll probably need to get permission from them.

Feel free to let me know if you've got any other questions about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment