The Wayback Machine - https://web.archive.org/web/20211202064548/https://github.com/strapi/strapi/issues/6475
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain name validation #6475

Open
sujaydeymountblue opened this issue May 31, 2020 · 5 comments
Open

Domain name validation #6475

sujaydeymountblue opened this issue May 31, 2020 · 5 comments
Labels
good first issue severity: low type: enhancement

Comments

@sujaydeymountblue
Copy link

@sujaydeymountblue sujaydeymountblue commented May 31, 2020

Describe the bug
At the time of registration, email has not been validated correctly http://localhost:1337/admin/auth/register

Expected behavior
An email should be valid in all aspect like

  • should check valid domain, well-formed and valid mailbox

Screenshots
invalid email1:
s1

invalid email2:
s2

invalid in the dashboard:
dashboard

System

Node.js version:v12.6.0
NPM version:6.9.0
Strapi version: 3.0.1
Database:mongodb
Operating system:Ubuntu 18.04
@lauriejim
Copy link
Member

@lauriejim lauriejim commented Jun 15, 2020

Hello!

Thank you for reporting this behavior.

Something I would super appreciate is if you can try to submit a PR to fix this issue.

The topic you are pointing has to be fixed and it could be done by someone from the Community (you 🤗).

Here is the contributing guide to help you to getting started for contributions to Strapi.
@lauriejim lauriejim changed the title At the time of registration, email has not been validated correctly Domain name validation Jun 15, 2020
@uporot1k
Copy link

@uporot1k uporot1k commented Jul 16, 2020

@lauriejim Hi! Which current status of this issue? Can i try to fix this problem?
@DJ-Icebear
Copy link

@DJ-Icebear DJ-Icebear commented Sep 1, 2020 •
edited
Loading

@sujaydeymountblue I get the second example - "comsfjdlkfj" is not an existing top level domain.

But what is wrong with "a@gmail.com". It's a valid email format as far as I can tell. Although Google themselves have enforced a min-6-char rule for new accounts (but there are still google employees and early adopters that have shorter email addresses).
@DJ-Icebear DJ-Icebear mentioned this issue Sep 4, 2020
Closed
pasha42 added a commit to pasha42/strapi that referenced this issue Feb 23, 2021
@pasha42
Issue: Domain name validation strapi#6475 Fixed
03c69f3
@pasha42 pasha42 mentioned this issue Feb 23, 2021
Closed
@ognjenjevremovic
Copy link
Contributor

@ognjenjevremovic ognjenjevremovic commented Feb 23, 2021

Hey @ lauriejim 👋
I see there are a few PR referencing this issue. Can you confirm that this issue have been addressed fully - including all 3 scenarios linked and that no further work is required?

If not, I would like to work on this if it is up for grabs an it has not been addressed yet 🙂 .
This seems like a good issue for first time contributors to the project.

Many thanks! 🎉
pasha42 added a commit to pasha42/strapi that referenced this issue Feb 25, 2021
@pasha42
Issue: Domain name validation strapi#6475 Fixed. With Ref to Previous…
73dcade 
… PR strapi#9496
@pasha42 pasha42 mentioned this issue Feb 25, 2021
Merged
alexandrebodin pushed a commit that referenced this issue Mar 1, 2021
@pasha42
Issue: Domain name validation #6475 Fixed. With Ref to Previous PR #9496
3781ca2 
 (#9521)
soupette added a commit that referenced this issue Mar 3, 2021
@soupette
Revert "Issue: Domain name validation #6475 Fixed. With Ref to Previo…
3d8e726 
…us PR #9496 (#9521)"

This reverts commit 3781ca2.
alexandrebodin pushed a commit that referenced this issue Mar 3, 2021
@soupette
Revert "Issue: Domain name validation c Fixed. With Ref to Previous PR …
31fff1e 
…#9496" (#9588)

* Revert "Issue: Domain name validation #6475 Fixed. With Ref to Previous PR #9496 (#9521)"

This reverts commit 3781ca2.

* Update yarn.lock

Signed-off-by: soupette <cyril.lpz@gmail.com>
@varadp2000
Copy link

@varadp2000 varadp2000 commented Aug 17, 2021

Hello, if this issue is still open, I am interested. First time contributor :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue severity: low type: enhancement
6 participants
@lauriejim @DJ-Icebear @ognjenjevremovic @uporot1k @varadp2000 @sujaydeymountblue