The Wayback Machine - https://web.archive.org/web/20211207015152/https://github.com/zsh-users/zsh-syntax-highlighting/issues/828
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions on sourcing from distro package installation #828

Open
Mario-paul opened this issue Aug 15, 2021 · 5 comments
Open

Add instructions on sourcing from distro package installation #828

Mario-paul opened this issue Aug 15, 2021 · 5 comments
Labels
Bug component:docs good first issue

Comments

@Mario-paul
Copy link

@Mario-paul Mario-paul commented Aug 15, 2021

Installed using the "Using packages" install how-to section for Ubuntu, but syntax highlighting does not work. .zshrc file obviously does not have sourcing information, and after trying all of the "source" lines from the INSTALL.md, it still doesn't work. clearly zsh-syntax-highlighting is installed somewhere different than the git installations, and those source lines won't work for the Ubuntu repo install.

Am I missing something? And if not, can the "Using packages" section be completed or cleared up?

Thanks
@danielshahaf
Copy link
Member

@danielshahaf danielshahaf commented Aug 15, 2021

You're right, we should spell that out.

In your case, see /usr/share/doc/zsh-syntax-highlighting/README.Debian.gz or dpkg -L zsh-syntax-highlighting for the path to zsh-syntax-highlighting.zsh.

Leaving this open to track the documentation change. If you'd like to propose new language for INSTALL.md, that'd be great :-)
@Mario-paul Mario-paul mentioned this issue Aug 18, 2021
Open
@Mario-paul
Copy link
Author

@Mario-paul Mario-paul commented Aug 18, 2021

Hey Daniel, using your help I got it working using the Ubuntu package install. I noticed the Ubuntu package for my distro base (20.04) is extremely outdated though (0.6.0) so I'm just gonna install the latest github version using the oh-my-zsh plugin way lol.

As requested, I added the instructions to source .zshrc file on debian/based package installs on INSTALL.md file. Hope that looks good, otherwise you are free to edit my changes as you like.
@danielshahaf
Copy link
Member

@danielshahaf danielshahaf commented Aug 18, 2021

Thanks! We'll review the PR when we have a moment. (And the next release milestone issues list too, so recent work will reach distro users too...)
@Mario-paul
Copy link
Author

@Mario-paul Mario-paul commented Aug 18, 2021

Thanks! We'll review the PR when we have a moment. (And the next release milestone issues list too, so recent work will reach distro users too...)

Other than some Cinnamon themes, this is my first real contribution to a Linux project. How exciting! :)
@danielshahaf
Copy link
Member

@danielshahaf danielshahaf commented Aug 20, 2021

Oh, congratulations! I still remember my first few patches. Even that day when I reported a typo on IRC and @lgov (hi!) committed it upon the spot with "Patch by:" credit…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug component:docs good first issue
2 participants
@danielshahaf @Mario-paul