The Wayback Machine - https://web.archive.org/web/20211120044124/https://github.com/aws/aws-cdk/pull/16691
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump node version for gitpod dev container #16691

Merged
merged 2 commits into from Sep 28, 2021
Merged

chore: bump node version for gitpod dev container #16691

merged 2 commits into from Sep 28, 2021

Conversation

@pahud
Copy link
Contributor

@pahud pahud commented Sep 28, 2021

This PR bumps the node version from v10 to v12 for the gitpod dev container using jsii/superchain.

Fixes: #16690

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Sep 28, 2021

@pahud pahud marked this pull request as ready for review Sep 28, 2021
@skinny85
Copy link
Contributor

@skinny85 skinny85 commented Sep 28, 2021

@pahud did you try to create a Gitpod workspace with this new setup (with the configuration from this branch)?
@pahud
Copy link
Contributor Author

@pahud pahud commented Sep 28, 2021

@pahud did you try to create a Gitpod workspace with this new setup (with the configuration from this branch)?

Yes I did. And it was great!

圖片

And the yarn build works as well.

圖片
peterwoodworth
peterwoodworth approved these changes Sep 28, 2021
View changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Looks great, thank you very much!
@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Sep 28, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a01cd55
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mergify mergify bot merged commit 6390cb5 into aws:master Sep 28, 2021
7 checks passed
Loading
@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@pahud @skinny85 @aws-cdk-automation @peterwoodworth