The Wayback Machine - https://web.archive.org/web/20220103052002/https://github.com/ajayyy/SponsorBlock/pull/1116
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embedded videos #1116

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Support embedded videos #1116

wants to merge 8 commits into from

Conversation

@mchangrh
Copy link
Contributor

@mchangrh mchangrh commented Dec 31, 2021

  • I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.

blocked by #1070
closes #1114

Skips work and the sponsorBlock button works but it seems that preview bar creation is abandoned since the navigate-finish event isn't fired.
@mchangrh
Copy link
Contributor Author

@mchangrh mchangrh commented Jan 1, 2022

What works/ doesn't

  • Submission UI
  • Auto Skipping
  • Show segments on seek bar
  • Skipping Notices
  • Skip to Highlight
  • Upload Button
  • Info Button
  • Starting/Ending segments
    • Button
    • Keypress
  • Delete Button
  • Extension popout from extensions list
  • Manual Skipping via keypress
  • Time with skips removed
@mchangrh mchangrh marked this pull request as ready for review Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@mchangrh @ajayyy