The Wayback Machine - https://web.archive.org/web/20200911183438/https://github.com/amundsen-io/amundsen/issues/646
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor text classes and styles #646

Open
Golodhros opened this issue Aug 19, 2020 · 2 comments
Open

Refactor text classes and styles #646

Golodhros opened this issue Aug 19, 2020 · 2 comments

Comments

@Golodhros
Copy link
Member

@Golodhros Golodhros commented Aug 19, 2020

We have a new set of text classes and placeholder classes to use on our text styles (https://github.com/amundsen-io/amundsenfrontendlibrary/blob/master/amundsen_application/static/css/_typography-default.scss#L12)
We want to use this going forward, but also want to remove all the current classes from our app.

Expected Behavior or Use Case

Visually, almost nothing should change

Possible Implementation

Use @extend %text-body-w2; or @extend %text-title-w2; instead of adding custom styling for text on our stylesheets
When using text classes (not recommended), use .text-title-w1/2/3 or .text-body-w1/2/3 instead of the current text classes like .h2, .h3, or .title, .subitle-*, etc.

Context

We want to have a consistent text implementation on our app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.