Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor text classes and styles #646
Open
Projects
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


We have a new set of text classes and placeholder classes to use on our text styles (https://github.com/amundsen-io/amundsenfrontendlibrary/blob/master/amundsen_application/static/css/_typography-default.scss#L12)
We want to use this going forward, but also want to remove all the current classes from our app.
Expected Behavior or Use Case
Visually, almost nothing should change
Possible Implementation
Use @extend %text-body-w2; or @extend %text-title-w2; instead of adding custom styling for text on our stylesheets
When using text classes (not recommended), use .text-title-w1/2/3 or .text-body-w1/2/3 instead of the current text classes like .h2, .h3, or .title, .subitle-*, etc.
Context
We want to have a consistent text implementation on our app.