The Wayback Machine - https://web.archive.org/web/20210815215254/https://github.com/salesagility/SuiteCRM/issues/9002
Skip to content

/ SuiteCRM

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid JSON response when creating user via V8 API #9002

Open
peterkappelt opened this issue Dec 29, 2020 · 5 comments
Open

Invalid JSON response when creating user via V8 API #9002

peterkappelt opened this issue Dec 29, 2020 · 5 comments
Labels
Area: Module Good First Issue Help Wanted Priority:Moderate Type:Suggestion

Comments

@peterkappelt
Copy link

@peterkappelt peterkappelt commented Dec 29, 2020 •
edited

Hey everyone, I hope y'all enjoyed your holidays.
I want to create SuiteCRM users via the V8 api, but the response is invalid json and contains some generic validation error message.

I'm not sure whether my request is actually malformed or the error message just shouldn't appear.

Issue

Create a new User by calling:
POST https://mysuitecrm.com/Api/V8/module

{
  "data": {
    "type": "Users",
    "attributes": {
      "user_name": "mail@example.org",
      "first_name": "John",
      "last_name": "Doe",
      "external_auth_only": 1,
      "status": "Active",
      "email1": "mail@example.org",
      "email_addresses": "mail@example.org",
      "email_addresses_primary": "mail@example.org"
    }
  }
}

The user will be created, but the response looks like this:

{
    "data": {
        "type": "User",
        "id": "1acd4bbf-7f8c-4e6f-aa92-5fea6e799b74",
        "attributes": {...}
    }
}Sie müssen einen Benutzernamen und eine E-Mail Adresse angeben.

The response includes the error messages string in the end. It translate to "You must specify a username and an e-mail address".

Expected Behavior

There shouldn't be any clear-text error messages appended to the JSON

Actual Behavior

There is a generic error message string appended to the JSON response

Possible Fix

Not sure

Steps to Reproduce

See above. Create User via API

Context

It's a blocker for me, since the API response can't be parsed properly by my user creation script.

Your Environment

  • SuiteCRM Version used: 7.11.15
@pgorod
Copy link
Contributor

@pgorod pgorod commented Dec 29, 2020

I'm just guessing, from a quick look, but I'd say...

User->save() calls User->saveFormPreferences, which has this line:

require_once 'modules/Users/GeneratePassword.php';

And inside that file there are several echo statements, namely

echo  $mod_strings['LBL_PROVIDE_USERNAME_AND_EMAIL'];

GeneratePassword.php is one of those files that should be completely refactored, no reason not to have that code in a proper class and separate processing from outputting screen information...
@peterkappelt
Copy link
Author

@peterkappelt peterkappelt commented Dec 29, 2020

I was able to fix this error by setting the user_hash attribute in the request, the error message now won't appear anymore.

Thank you for the hint. For me, this issue is now low priority since I was able to find a workaround.
@Mac-Rae
Copy link
Contributor

@Mac-Rae Mac-Rae commented Jan 4, 2021

I could be missing something, however, this doesn't look like an issue to me.

The system will always require a user_hash to be set, even if external auth is required. Therefore this only really comes down to an error message which could do with being slightly improved, no?
@peterkappelt
Copy link
Author

@peterkappelt peterkappelt commented Jan 4, 2021

Well, yes and no.

The improvement of the error message and the input validation is definitely one side of the problem. The error message is a bit misleading, since it literally says "You must specify an username and a mail address" - so I had no clue it was about the missing password. Also, it should definitely be JSON-formatted. I think this should be sufficient for fixing this issue. I could do it myself, though @pgorod suggested to do a complete refactoring of GeneratePassword.php - I don't have resources to do that.

On my SuiteCRM instance, I observed that the system set user_hash to NULL if a user was created via LDAP. I expected the same thing to be the case when creating users with the API for SAML auth. How is it supposed to work?
@pgorod
Copy link
Contributor

@pgorod pgorod commented Jan 4, 2021

Removing the echo from a function that is called on a Bean save is a bug that need to be fixed. It can break the system in many unexpected ways.

The minimum fix, without any big rewrites, is removing the echo commands and ensuring that errors are showing correctly when called from the UI, and that when calling from the API the return is valid JSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Module Good First Issue Help Wanted Priority:Moderate Type:Suggestion
3 participants
@peterkappelt @pgorod @Mac-Rae