The Wayback Machine - https://web.archive.org/web/20211229223809/https://github.com/apache/dolphinscheduler/pull/7690
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][UI Next] Add layout content, theme and i18n. #7690

Merged
merged 1 commit into from Dec 28, 2021
Merged

[Feature][UI Next] Add layout content, theme and i18n. #7690

merged 1 commit into from Dec 28, 2021

Conversation

@songjianet
Copy link
Contributor

@songjianet songjianet commented Dec 28, 2021

Purpose of the pull request

close #7673

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:
labbomb
labbomb approved these changes Dec 28, 2021
View changes
Copy link
Contributor

@labbomb labbomb left a comment

LGTM
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #7690 (d1e2d90) into dev (0a7610d) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7690      +/-   ##
============================================
- Coverage     41.26%   41.10%   -0.17%     
- Complexity     3675     3676       +1     
============================================
  Files           641      642       +1     
  Lines         26555    26649      +94     
  Branches       2972     2989      +17     
============================================
- Hits          10958    10954       -4     
- Misses        14565    14650      +85     
- Partials       1032     1045      +13
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...er/master/processor/queue/TaskResponseService.java 50.00% <0.00%> (-18.19%) ⬇️
...olphinscheduler/rpc/remote/NettyServerHandler.java 69.04% <0.00%> (-7.15%) ⬇️
...rver/master/processor/queue/TaskResponseEvent.java 93.54% <0.00%> (-6.46%) ⬇️
...lphinscheduler/rpc/client/ConsumerInterceptor.java 89.13% <0.00%> (-2.18%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...r/server/master/registry/MasterRegistryClient.java 38.07% <0.00%> (-0.97%) ⬇️
...inscheduler/server/master/config/MasterConfig.java 69.56% <0.00%> (-0.44%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-0.44%) ⬇️
...er/server/master/runner/WorkflowExecuteThread.java 9.94% <0.00%> (-0.10%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7610d...d1e2d90. Read the comment docs.
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Dec 28, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
39.0% 39.0% Duplication
@kezhenxu94 kezhenxu94 merged commit 9f9ddea into apache:dev Dec 28, 2021
8 of 9 checks passed
@songjianet songjianet deleted the feat-layout branch Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@songjianet @codecov-commenter @labbomb @kezhenxu94