The Wayback Machine - https://web.archive.org/web/20211229081207/https://github.com/square/leakcanary/issues/2185
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build custom Toast view for Android TV #2185

Open
Armaxis opened this issue Oct 1, 2021 · 5 comments
Open

Build custom Toast view for Android TV #2185

Armaxis opened this issue Oct 1, 2021 · 5 comments

Comments

@Armaxis
Copy link
Member

@Armaxis Armaxis commented Oct 1, 2021

Problem description

TvToast displays a custom Toast on Android TV devices. It does so by modifying the Toast.getView()'s message TextView.

On Android 30+ it is no longer allowed to access toast's view via getView() and it led to crashes (see #2161). Custom toasts were disabled for devices running API 30+

We should try to build custom toasts on API 30+ devices as well, probably by doing the same thing we do for mobile LeakCanary custom toast.

@FareesHussain
Copy link

@FareesHussain FareesHussain commented Oct 29, 2021

Hey @Armaxis
Can I pick this up?

@RakeshBorase
Copy link

@RakeshBorase RakeshBorase commented Oct 31, 2021

hi

@Armaxis
Copy link
Member Author

@Armaxis Armaxis commented Nov 1, 2021

@FareesHussain of course! Thank you!

@pyricau
Copy link
Member

@pyricau pyricau commented Dec 15, 2021

contribution welcome!

@MohitMandalia
Copy link

@MohitMandalia MohitMandalia commented Dec 18, 2021

@pyricau and @Armaxis I want to help here can we discuss how should we handle this issue. As if the toast is triggered in background app will crash
Please let me know.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment