The Wayback Machine - https://web.archive.org/web/20211016225723/https://github.com/rahuldkjain/github-profile-readme-generator/issues/287
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social button generator adding "/" even when there is no url base. #287

Open
datejer opened this issue Oct 21, 2020 · 1 comment
Open

Social button generator adding "/" even when there is no url base. #287

datejer opened this issue Oct 21, 2020 · 1 comment
Assignees
@datejer
Labels
bug good first issue hacktoberfest
Projects
GitHub Profile README Generator

Comments

@datejer
Copy link
Contributor

@datejer datejer commented Oct 21, 2020

Describe the bug
Whenever a social button is generated it takes the URL base and the username and puts a "/" in between them. This might cause a problem with the RSS URL. Since it takes a whole URL from the user there's no base URL. That causes it to generate with a / in front of the link provided by the user. In this case, the hyperlink is interpreted as a subpage, not an external website.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Social section
  2. Enter any link into the RSS field
  3. Generate the markdown
  4. Click the generated button to see the error

Expected behavior
This behavior should only be in place for URLs that have a base, otherwise, it should put only the link as the hyperlink.

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 86.0.4240.75

Smartphone (please complete the following information):

  • Device: Huawei P10
  • OS: Android 9
  • Browser Chrome
  • Version 86.0.4240.00

Additional context
N/A

Join the Discord Server for further discussions.
Server Link: https://discord.gg/HHMs7Eg
@datejer datejer added the bug label Oct 21, 2020
@datejer
Copy link
Contributor Author

@datejer datejer commented Oct 21, 2020

This would be a relatively easy fix, I reckon I can do this one.
@ghost ghost assigned datejer Oct 21, 2020
@ghost ghost added the good first issue label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue hacktoberfest
2 participants
@rahuldkjain @datejer