The Wayback Machine - https://web.archive.org/web/20211228091409/https://github.com/nukeop/nuclear/issues/1012
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI | Unify Right clik behavior #1012

Open
mlovizio opened this issue Jul 11, 2021 · 5 comments · May be fixed by #1121
Open

GUI | Unify Right clik behavior #1012

mlovizio opened this issue Jul 11, 2021 · 5 comments · May be fixed by #1121
Assignees
@TomasHvisc
Labels
enhancement good first issue

Comments

@mlovizio
Copy link

@mlovizio mlovizio commented Jul 11, 2021

Unify Right clik behavior for context menus

Currently to access the options menu of a song, the button you have to press varies depending on where you are located, in the main window while selecting tracks the menu appears using left click but in the playlist it appears using the right click as expected.

 

Suggestion

Change the current behavior of the right click to always open an options menu, to maintain the same logic everywhere in the GUI and make the user experience consistent across all sections of the GUI and a bit more intuitive as a result of that.
@tio-trom
Copy link

@tio-trom tio-trom commented Jul 18, 2021

100% this! :) It is indeed a bit confusing the way it is now.
@TomasHvisc
Copy link

@TomasHvisc TomasHvisc commented Oct 7, 2021

Hi, I would like to contribute to this.
@nukeop
Copy link
Owner

@nukeop nukeop commented Oct 7, 2021

Sure, I'll assign you. Do you need any hints?
@TomasHvisc
Copy link

@TomasHvisc TomasHvisc commented Oct 8, 2021

Should both ways look like in main windows or playlist? Also this is my first contribution, but I will try my best.
@nukeop
Copy link
Owner

@nukeop nukeop commented Oct 8, 2021

I think those context menus should always be opened with a right click. It should just be a matter of changing the prop the callback goes to. If you need any help, let me know here on Github, or on Discord or Matrix.
@HaiDang666 HaiDang666 linked a pull request that will close this issue Dec 11, 2021
Unify context popup behavior (open on right click everywhere) #1121
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
5 participants
@nukeop @HaiDang666 @tio-trom @TomasHvisc @mlovizio