The Wayback Machine - https://web.archive.org/web/20220629162902/https://github.com/iv-org/invidious/issues/2551
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still shows reddit comment button while YouTube is set to default comment #2551

Open
hellojaccc opened this issue Oct 31, 2021 · 4 comments
Open

Still shows reddit comment button while YouTube is set to default comment #2551

hellojaccc opened this issue Oct 31, 2021 · 4 comments
Labels
good first issue type:client-side

Comments

@hellojaccc
Copy link
Contributor

@hellojaccc hellojaccc commented Oct 31, 2021 •
edited

Screenshot_20211031_172304
^ Only YouTube is selected in default comment
Screenshot_20211031_172425
^ It still shows 'show reddit comment' button
@SamantazFox
Copy link
Member

@SamantazFox SamantazFox commented Nov 1, 2021 •
edited

Hello! Thanks for reporting this issue :) Could you please give more details about this issue, like the instance URL and/or version (this can be found in the footer of the webpage)?

Also, is the problem due to the language, or does it happen in english too?
@SamantazFox SamantazFox added bug good first issue type:client-side labels Nov 1, 2021
@hellojaccc
Copy link
Contributor Author

@hellojaccc hellojaccc commented Nov 1, 2021 •
edited

Hi, thanks for looking into my issue :)

invidious.osi.kr
2021.10.26-2b81a82 @ master

It also happens on English language.
@SamantazFox
Copy link
Member

@SamantazFox SamantazFox commented Nov 2, 2021

Ok, so I checked the source code, and it's a deliberate design made by @omarroth:

  • When you select youtube comments, it will show a "view reddit comments" link
  • and vice-versa, when you select reddit comments, it will show the link to get the youtube ones.
@SamantazFox SamantazFox removed the bug label Nov 2, 2021
@hellojaccc
Copy link
Contributor Author

@hellojaccc hellojaccc commented Nov 12, 2021

Lots of video i watch doesn't have reddit comment, so it's not useful for me.

I think not selecting reddit comments in settings should show no reddit comments button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue type:client-side
2 participants
@SamantazFox @hellojaccc