The Wayback Machine - https://web.archive.org/web/20201117212920/https://github.com/pastelsky/bundlephobia/issues/424
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image caching is too aggressive #424

Open
pizzafox opened this issue Nov 1, 2020 · 0 comments
Open

Image caching is too aggressive #424

pizzafox opened this issue Nov 1, 2020 · 0 comments
Labels
bug

Comments

@pizzafox
Copy link

@pizzafox pizzafox commented Nov 1, 2020

Describe the bug

When using an image URL like https://bundlephobia.com/api/stats-image?name=convert&version=1.0.1&wide=true for a version that isn't published the image returns a placeholder, but the placeholder gets cached. After the version is published the placeholder image stays cached.

To Reproduce

Visit an image URL for a version that didn't exist at image generation time.

Example: https://bundlephobia.com/api/stats-image?name=convert&version=1.1.0&wide=true

} catch (err) {
console.error(err)
await send(ctx, 'client/assets/public/android-chrome-192x192.png')
}

Expected behavior

There should be a much shorter cache period for placeholder images.

@pizzafox pizzafox added the bug label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.