The Wayback Machine - https://web.archive.org/web/20220125175246/https://github.com/apache/kafka/pull/9849
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Upgrade gradle to 6.8 and test retry plugin to 1.2.0 #9849

Merged
merged 6 commits into from Jan 18, 2021
Merged

MINOR: Upgrade gradle to 6.8 and test retry plugin to 1.2.0 #9849

merged 6 commits into from Jan 18, 2021

Conversation

@ijuma
Copy link
Contributor

@ijuma ijuma commented Jan 8, 2021 •
edited

Also fix generation of gradlew when APP_HOME contains a directory with spaces
in its name.

Release notes:

In addition to existing tests, verified that ./gradlewAll jar succeeds.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@chia7712
Copy link
Contributor

@chia7712 chia7712 commented Jan 10, 2021

https://github.com/apache/kafka/blob/trunk/gradle/wrapper/gradle-wrapper.properties#L3 need to be updated as well.
@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Jan 10, 2021

Yeah, this is not complete yet (hence the draft status). :)
@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Jan 14, 2021

I updated the PR, but I need to verify that Jenkins handles merged reruns correctly. If not, I will revert that part of the change.
@ijuma ijuma marked this pull request as ready for review Jan 17, 2021
@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Jan 17, 2021

I reverted the flaky test reporting changes and filed a JIRA with the details of what is required (and missing):

https://issues.apache.org/jira/browse/KAFKA-12216
@ijuma ijuma mentioned this pull request Jan 17, 2021
Closed
@ijuma ijuma requested review from gwenshap and chia7712 Jan 17, 2021
@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Jan 18, 2021

@chia7712 Thoughts on this PR?
chia7712
chia7712 approved these changes Jan 18, 2021
View changes
Copy link
Contributor

@chia7712 chia7712 left a comment

+1
@ijuma ijuma merged commit 1ca497a into trunk Jan 18, 2021
0 of 10 checks passed
@ijuma ijuma deleted the gradle-6.8 branch Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@ijuma @chia7712