MINOR: fix the path metadata shell uses for client quotas #11437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
approved these changes
Oct 26, 2021
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: add back newline
cmccabe
force-pushed
the
fix-metadata-shell-client-quotas
branch
from
4114a35
to
795d74e
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this issue
Dec 22, 2021
Client quotas should appear under /client-quotas rather than /configs, since client quotas are not configs. Additionally we should correctly handle the case where the entity name is null (aka "default" quotas.) Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Client quotas should appear under /client-quotas rather than /configs, since client quotas are
not configs. Additionally we should correctly handle the case where the entity name is null
(aka "default" quotas.)
The text was updated successfully, but these errors were encountered: