The Wayback Machine - https://web.archive.org/web/20220125174748/https://github.com/apache/kafka/pull/10671
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: exclude all src/generated and src/generated-test #10671

Merged
merged 1 commit into from May 12, 2021
Merged

MINOR: exclude all src/generated and src/generated-test #10671

merged 1 commit into from May 12, 2021

Conversation

@chia7712
Copy link
Contributor

@chia7712 chia7712 commented May 11, 2021

for #10637 (comment)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@chia7712 chia7712 requested a review from ableegoldman May 11, 2021
@chia7712 chia7712 mentioned this pull request May 11, 2021
Merged
3 tasks
ableegoldman
ableegoldman approved these changes May 11, 2021
View changes
Copy link
Contributor

@ableegoldman ableegoldman left a comment

Thanks @chia7712 . Can you verify this by creating some test directories/file that follow this pattern, and make sure they don't show up? I had a vague impression that .gitignore files don't allow regular regexes and followed some niche syntax instead, but I'm not sure.

I'll leave it up to you to test and then merge if successful
@chia7712
Copy link
Contributor Author

@chia7712 chia7712 commented May 12, 2021

Thanks @chia7712 . Can you verify this by creating some test directories/file that follow this pattern, and make sure they don't show up? I had a vague impression that .gitignore files don't allow regular regexes and followed some niche syntax instead, but I'm not sure.

the gitignore documentation (https://git-scm.com/docs/gitignore) has following example:
A leading "**" followed by a slash means match in all directories. For example, "**/foo" matches file or directory "foo" anywhere, the same as pattern "foo". "**/foo/bar" matches file or directory "bar" anywhere that is directly under directory "foo".

I add file to src/generated and aaa/src/generated and they are excluded.

截圖 2021-05-12 下午3 19 00
@chia7712 chia7712 merged commit 9c9ea30 into apache:trunk May 12, 2021
10 checks passed
ijuma added a commit to ijuma/kafka that referenced this issue May 16, 2021
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into reduce-produc…
00c29d0 
…e-allocations-lz4

* apache-github/trunk: (155 commits)
  KAFKA-12728: Upgrade gradle to 7.0.2 and shadow to 7.0.0 (apache#10606)
  KAFKA-12778: Fix QuorumController request timeouts and electLeaders (apache#10688)
  KAFKA-12754: Improve endOffsets for TaskMetadata (apache#10634)
  Rework on KAFKA-3968: fsync the parent directory of a segment file when the file is created (apache#10680)
  MINOR: set replication.factor to 1 to make StreamsBrokerCompatibilityService work with old broker (apache#10673)
  MINOR: prevent cleanup() from being called while Streams is still shutting down (apache#10666)
  KAFKA-8326: Introduce List Serde (apache#6592)
  KAFKA-12697: Add Global Topic and Partition count metrics to the Quorum Controller (apache#10679)
  KAFKA-12648: MINOR - Add TopologyMetadata.Subtopology class for subtopology metadata (apache#10676)
  MINOR: Update jacoco to 0.8.7 for JDK 16 support (apache#10654)
  MINOR: exclude all `src/generated` and `src/generated-test` (apache#10671)
  KAFKA-12772: Move all transaction state transition rules into their states (apache#10667)
  KAFKA-12758 Added `server-common` module to have server side common classes.  (apache#10638)
  MINOR Removed copying storage libraries specifically as they are already copied. (apache#10647)
  KAFKA-5876: KIP-216 Part 4, Apply InvalidStateStorePartitionException for Interactive Queries (apache#10657)
  KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix (apache#10643)
  MINOR: remove unnecessary placeholder from WorkerSourceTask#recordSent (apache#10659)
  MINOR: Remove unused `scalatest` definition from `dependencies.gradle` (apache#10655)
  MINOR: checkstyle version upgrade: 8.20 -> 8.36.2 (apache#10656)
  KAFKA-12464: minor code cleanup and additional logging in constrained sticky assignment (apache#10645)
  ...
satishd added a commit to satishd/kafka that referenced this issue May 31, 2021
@chia7712 @satishd
MINOR: exclude all src/generated and src/generated-test (apache#1…
fc1ec96 
…0671)

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
kamalcph added a commit to satishd/kafka that referenced this issue Jun 21, 2021
@chia7712 @kamalcph
MINOR: exclude all src/generated and src/generated-test (apache#1…
0f2119b 
…0671)

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
satishd added a commit to satishd/kafka that referenced this issue Aug 12, 2021
@chia7712 @satishd
MINOR: exclude all src/generated and src/generated-test (apache#1…
e503896 
…0671)

Summary:
author: Chia-Ping Tsai <chia7712@gmail.com> on 12/05/21 at 12:57 pm
apache-reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
(cherry picked from commit 9c9ea30)

Reviewers: #ldap_kafka_admins, satishd

Reviewed By: #ldap_kafka_admins, satishd

JIRA Issues: DKAFC-868

Differential Revision: https://code.uberinternal.com/D6303249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@chia7712 @ableegoldman