The Wayback Machine - https://web.archive.org/web/20211106101155/https://github.com/BoostIO/BoostNote-Legacy/pull/3498
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated PR template #3498

Merged
merged 2 commits into from Feb 28, 2020
Merged

updated PR template #3498

merged 2 commits into from Feb 28, 2020

Conversation

Labels
approved 👍
3 participants
@ZeroX-DG @Flexo013 @Rokt33r
@ZeroX-DG
Copy link
Member

@ZeroX-DG ZeroX-DG commented Feb 26, 2020 •
edited
Loading

Description

This PR update the pull request template to include necessary question about UI or keybinding

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
@ZeroX-DG
updated PR template
3294295
Flexo013
Flexo013 reviewed Feb 26, 2020
View changes
PULL_REQUEST_TEMPLATE.md Outdated
@@ -34,3 +38,5 @@ Change :white_circle: to :radio_button: in all the options that apply
- :white_circle: I have written test for my code and it has been tested
- :white_circle: All existing tests have been passed
- :white_circle: I have attached a screenshot/video to visualize my change if possible
- :white_circle: This PR will modify the UI or affects the UX
- :white_circle: This PR will add/update/delete keybinding
Copy link
Contributor

@Flexo013 Flexo013 Feb 26, 2020

Better English would be:

This PR will add/update/delete a keybinding
Copy link
Member Author

@ZeroX-DG ZeroX-DG Feb 26, 2020

Oops:) I'll fix it right away
@ZeroX-DG
fixed grammar
b03177f
@Rokt33r Rokt33r added this to the v0.15.1 milestone Feb 28, 2020
@Rokt33r Rokt33r merged commit 88e8d2e into BoostIO:master Feb 28, 2020
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment