The Wayback Machine - https://web.archive.org/web/20211127132823/https://github.com/kingToolbox/WindTerm/issues/62
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have created a theme, how can I share it? #62

Open
lpadula opened this issue Mar 14, 2021 · 5 comments
Open

I have created a theme, how can I share it? #62

lpadula opened this issue Mar 14, 2021 · 5 comments

Comments

@lpadula
Copy link

@lpadula lpadula commented Mar 14, 2021

I have created a dracula theme for this awesome terminal:

dracula.zip

Is there a way to push it into the repo?

@kingToolbox
Copy link
Owner

@kingToolbox kingToolbox commented Mar 15, 2021

Wow, it is so amazing. You are the first contributor to WindTerm, thank you very very much!

I will build and provide ways to share, such as a themes folder and "Pull requests". In addition, would you like to authorize me to distribute your theme and WindTerm together? And put your name on the list of contributors?

In addition, there are two small problems. One is background-color of #TextPreview. You need to set transparency of the color to ensure the preview content visible, and it is also better to set a color different from the view background color, so that the preview content can be distinguished well. In addition, It would be better if the scroll bar is always visible, and unlike MacOS, there is no auto-hide scrollbar in Windows (Windows 10 provides while that feature is limited to (mostly) Windows Store applications and not desktop apps), so the scroll bar cannot be found quickly after hiding.

I will provide more detailed documentation and interface in subsequent versions as soon as possible to better provide assistance and convenience for customization of themes, keyboards, etc. Thank you again!

@Shellfishgene
Copy link

@Shellfishgene Shellfishgene commented May 5, 2021

Text selections are invisible in this theme...

@kingToolbox
Copy link
Owner

@kingToolbox kingToolbox commented May 5, 2021

I think this may be that the color of the selection is not set correctly, you can open the configuration file themes/dracula/scheme.theme and modify:

{
	"name": "text.selection",
	"style": {
		"foreground": "#282A36",
		"background": "#282A36",
		"decorationStyle": "roundBox"
	}
},

to:

{
	"name": "text.selection",
	"style": {
		"foreground": "#805050FF",
		"background": "#805050FF",
		"decorationStyle": "roundBox"
	}
},

The color #805050FF here is just a demonstration, and the foreground and background colors can also take different color values. You can set them to any colors you like, but it is best to both set the alpha channel.

@lpadula
Copy link
Author

@lpadula lpadula commented May 6, 2021

New version here: dracula.zip

@Shellfishgene
Copy link

@Shellfishgene Shellfishgene commented May 6, 2021

Thanks, works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment