The Wayback Machine - https://web.archive.org/web/20220111020339/https://github.com/TheAlgorithms/Python/pull/5799
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Type annotations for searches directory #5799

Merged
merged 10 commits into from Nov 9, 2021
Merged

[mypy] Type annotations for searches directory #5799

merged 10 commits into from Nov 9, 2021

Conversation

@Rohanrbharadwaj
Copy link
Contributor

@Rohanrbharadwaj Rohanrbharadwaj commented Nov 9, 2021

Describe your change:

Related to #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Rohanrbharadwaj
Copy link
Contributor Author

@Rohanrbharadwaj Rohanrbharadwaj commented Nov 9, 2021 •
edited

searches/simulated_annealing.py has a missing import error..
cclauss
cclauss approved these changes Nov 9, 2021
View changes
@cclauss cclauss merged commit 745f9e2 into TheAlgorithms:master Nov 9, 2021
2 checks passed
@cclauss cclauss mentioned this pull request Nov 9, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement tests are failing
2 participants
@Rohanrbharadwaj @cclauss