The Wayback Machine - https://web.archive.org/web/20220111020428/https://github.com/TheAlgorithms/Python/pull/5626
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all_construct dynamic programming implementation #5626

Merged
merged 10 commits into from Nov 4, 2021
Merged

Add all_construct dynamic programming implementation #5626

merged 10 commits into from Nov 4, 2021

Conversation

@werewolf-65
Copy link
Contributor

@werewolf-65 werewolf-65 commented Oct 27, 2021 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@werewolf-65 werewolf-65 requested a review from Kush1101 as a code owner Oct 27, 2021
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 27, 2021
View changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
dynamic_programming/all_construct.py Outdated Show resolved Hide resolved
dynamic_programming/all_construct.py Outdated Show resolved Hide resolved
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 27, 2021
View changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
dynamic_programming/all_construct.py Outdated Show resolved Hide resolved
@werewolf-65 werewolf-65 requested a review from cclauss Oct 28, 2021
cclauss
cclauss reviewed Nov 2, 2021
View changes
dynamic_programming/all_construct.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Nov 2, 2021
View changes
dynamic_programming/all_construct.py Outdated

if word_bank is None:
word_bank = []
Copy link
Member

@cclauss cclauss Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safer in the presence of other falsey values...

Suggested change
if word_bank is None:
word_bank = []
word_bank = word_bank or []
Copy link
Contributor Author

@werewolf-65 werewolf-65 Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is cleaner. Will update.
cclauss
cclauss reviewed Nov 3, 2021
View changes
dynamic_programming/all_construct.py Outdated
"""


def all_construct(target: str, word_bank: list[str] = None) -> list[list[str]]:
Copy link
Member

@cclauss cclauss Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list[str] = None makes no sense because None is not a list.

Suggested change
def all_construct(target: str, word_bank: list[str] = None) -> list[list[str]]:
def all_construct(target: str, word_bank: list[str] | None = None) -> list[list[str]]:
Copy link
Contributor Author

@werewolf-65 werewolf-65 Nov 3, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the article you mentioned previously regarding mutable default arguments
(https://docs.python-guide.org/writing/gotchas/)
and I don't see a problem in defining a default argument as None and later changing it to an empty list in the code.
Copy link
Contributor Author

@werewolf-65 werewolf-65 Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I think I see.
do you mean the type hint is not clear that way?
@werewolf-65 werewolf-65 requested a review from cclauss Nov 3, 2021
@werewolf-65 werewolf-65 requested a review from cclauss Nov 3, 2021
@cclauss
Copy link
Member

@cclauss cclauss commented Nov 3, 2021

mypy not happy... Can you run it on your machine?

dynamic_programming/all_construct.py:27: error: List item 0 has incompatible type "List[<nothing>]"; expected "str"
dynamic_programming/all_construct.py:36: error: List comprehension has incompatible type List[List[str]]; expected List[str]
dynamic_programming/all_construct.py:36: error: Unsupported operand types for + ("List[str]" and "str")
dynamic_programming/all_construct.py:43: error: "str" has no attribute "reverse"
dynamic_programming/all_construct.py:45: error: Incompatible return value type (got "List[str]", expected "List[List[str]]")
@werewolf-65
Copy link
Contributor Author

@werewolf-65 werewolf-65 commented Nov 3, 2021

mypy not happy... Can you run it on your machine?

dynamic_programming/all_construct.py:27: error: List item 0 has incompatible type "List[<nothing>]"; expected "str"
dynamic_programming/all_construct.py:36: error: List comprehension has incompatible type List[List[str]]; expected List[str]
dynamic_programming/all_construct.py:36: error: Unsupported operand types for + ("List[str]" and "str")
dynamic_programming/all_construct.py:43: error: "str" has no attribute "reverse"
dynamic_programming/all_construct.py:45: error: Incompatible return value type (got "List[str]", expected "List[List[str]]")

I think it's a problem with a type hint I defined for 'table' . Testing it.
@werewolf-65
Copy link
Contributor Author

@werewolf-65 werewolf-65 commented Nov 3, 2021

mypy not happy... Can you run it on your machine?

dynamic_programming/all_construct.py:27: error: List item 0 has incompatible type "List[<nothing>]"; expected "str"
dynamic_programming/all_construct.py:36: error: List comprehension has incompatible type List[List[str]]; expected List[str]
dynamic_programming/all_construct.py:36: error: Unsupported operand types for + ("List[str]" and "str")
dynamic_programming/all_construct.py:43: error: "str" has no attribute "reverse"
dynamic_programming/all_construct.py:45: error: Incompatible return value type (got "List[str]", expected "List[List[str]]")

Fixed..
@werewolf-65
Copy link
Contributor Author

@werewolf-65 werewolf-65 commented Nov 4, 2021 •
edited

Build is getting errors on some other files . Could you check it please? @cclauss
cclauss
cclauss approved these changes Nov 4, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM
@cclauss cclauss merged commit 3815a97 into TheAlgorithms:master Nov 4, 2021
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests are failing
2 participants
@werewolf-65 @cclauss