The Wayback Machine - https://web.archive.org/web/20220417161832/https://github.com/openstreetmap/iD/issues/8750
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow operation should prefer the focused way #8750

Open
1ec5 opened this issue Oct 13, 2021 · 4 comments
Open

Follow operation should prefer the focused way #8750

1ec5 opened this issue Oct 13, 2021 · 4 comments
Labels
enhancement good first issue

Comments

@1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Oct 13, 2021 •
edited

The “follow” operation added in #8671 stops when encountering a node that’s shared among multiple features. iD already keeps track of the “focused” way for the purpose of reliably navigating back and forth among its vertices using the keyboard. It would be natural to extend this capability to the follow operation, so that the user doesn’t have to think as much about other connecting ways after choosing a way to follow. Invoking the follow operation would focus the way, and subsequent follow operations would choose that way from among the candidate ways.

iD/modules/modes/select.js

Line 150 in 7699034

function parentWayIdForVertexNavigation() {

iD/modules/modes/select.js

Lines 48 to 50 in 7699034

// `_focusedParentWayId` is used when we visit a vertex with multiple
// parents, and we want to remember which parent line we started on.
var _focusedParentWayId;

@1ec5 1ec5 added the enhancement label Oct 13, 2021
@1ec5 1ec5 mentioned this issue Oct 28, 2021
Merged
@mbrzakovic mbrzakovic added the good first issue label Nov 2, 2021
@Pho3b
Copy link

@Pho3b Pho3b commented Jan 23, 2022

Hi and nice to meet you @mbrzakovic @1ec5 , i would like to try and work on this issue if possible.
@tordans tordans mentioned this issue Feb 11, 2022
Open
@thyrhone
Copy link

@thyrhone thyrhone commented Mar 2, 2022

is it still possible to work on this?
@1ec5
Copy link
Collaborator Author

@1ec5 1ec5 commented Mar 2, 2022

Thanks for your interest! There’s a fix available in #8978; perhaps you could help review it?
@sherryboxall
Copy link

@sherryboxall sherryboxall commented Mar 4, 2022

Hello @mbrzakovic @1ec5 ,

I would like to help work on this issue if possible. Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
5 participants
@1ec5 @Pho3b @mbrzakovic @thyrhone @sherryboxall