The Wayback Machine - https://web.archive.org/web/20201023025947/https://github.com/CodelyTV/pr-size-labeler/issues/19
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeats the "this pr is too big" message #19

Open
TheTechRobo opened this issue Aug 16, 2020 · 4 comments
Open

Repeats the "this pr is too big" message #19

TheTechRobo opened this issue Aug 16, 2020 · 4 comments

Comments

@TheTechRobo
Copy link

@TheTechRobo TheTechRobo commented Aug 16, 2020

whenever i push it repeats it. really annoying as i keep getting notifications for nothing.

@JavierCane
Copy link
Member

@JavierCane JavierCane commented Aug 17, 2020

Hi!

As you can see in this example, it publishes the mentioned comment one time for each Workflow execution. That is, it depends on your on clause configuration (example).

Could you please link or attach your yaml configuration and a screenshot of the duplicated message in a PR? (Wipe out sensible information if that's the case)

This could help debugging or reproducing the issue 🙂

Thanks!

@TheTechRobo
Copy link
Author

@TheTechRobo TheTechRobo commented Aug 17, 2020

name: labeler

on: [pull_request]

jobs:
  labeler:
    runs-on: ubuntu-latest
    name: Label the PR size
    steps:
      - uses: codelytv/pr-size-labeler@v1
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          xs_max_size: '10'
          s_max_size: '100'
          m_max_size: '500'
          l_max_size: '1000'
          fail_if_xl: 'false'
          message_if_xl: 'This PR is extremely big! Please, split it 😊'

image

@JavierCane
Copy link
Member

@JavierCane JavierCane commented Aug 19, 2020

Thanks for the information! 🙌

As we can see in the screenshot, it publishes a comment regarding the PR size being too big for every new commit, that is, on every chance the PR has had to modify its size.

We could have some kind of logic taking into account the previous labels. I mean:

  1. Check if the PR already have the size/xl label and if that's the case:
    1.a. If it's still too big, publish a comment like "This PR is still too big 😬"
    1.b. If it has been reduced from size/xl to any other size, publish a comment like "Congrats! 🎉 You have reduced the PR size successfully!"

What do you think? Would it be better?

@TheTechRobo
Copy link
Author

@TheTechRobo TheTechRobo commented Aug 19, 2020

What do you think? Would it be better?

Yeah! It would also be nice to be able to set e.g. it will check the size every commit, but for commits on the same day it will not say this, i.e. the first commit on august 21 will have the message, but subsequent commits on that day will not show the message, andthe first commit on august 22 will have the message etc to reduce clutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.