The Wayback Machine - https://web.archive.org/web/20211002014029/https://github.com/monicahq/monica/issues/1304
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SMS link clickable #1304

Open
djaiss opened this issue May 10, 2018 · 7 comments
Open

Make SMS link clickable #1304

djaiss opened this issue May 10, 2018 · 7 comments

Comments

@djaiss
Copy link
Member

@djaiss djaiss commented May 10, 2018

Right now SMS field is not clickable. It should be so it opens the default OS app that let you send messages.

https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/SMSLinks/SMSLinks.html#//apple_ref/doc/uid/TP40007899-CH7-SW1

@nickescobedo
Copy link

@nickescobedo nickescobedo commented May 10, 2018

@djaiss Can I take this? I noticed the good first issue label. 😄

@nickescobedo
Copy link

@nickescobedo nickescobedo commented May 11, 2018

@djaiss
Which SMS field are you referring to? Someone can add a contact field type with the sms: protocol. Are you saying to have a default SMS contact field out of the box on a fresh install? Thanks!

@Wulfheart
Copy link

@Wulfheart Wulfheart commented May 22, 2019

@nickescobedo Did you already start a pull request?

@nickescobedo
Copy link

@nickescobedo nickescobedo commented May 28, 2019

@Wulfheart No I haven't done anything. Didn't understand what the ask was here.

@tbirrell
Copy link
Contributor

@tbirrell tbirrell commented Oct 21, 2019

This needs to be clarified. Right now you'll have to pick between sms: and tel:. OR add the option to allow the user to declare a global preference. OR allow users to pick between one or the other (which is solved by adding another protocol to default seeders).

Honestly the best option is to probably figure out how to do a long-tap context menu that lets you pick which action you want.

@pqhf5kd
Copy link

@pqhf5kd pqhf5kd commented Oct 22, 2019

How about declaring a global preference and adding an icon for the opposite action next to the number.

@divinity76
Copy link

@divinity76 divinity76 commented Jun 12, 2020

i suggest closing this issue as "invalid" (configuration issue) - OR solved (if the following wasn't possible back in 2018 when the issue was created)

if the SMS field under "CONTACT INFORMATION" is not clickable, then it's just a configuration issue, not a bug, make sure the "protocol" for the contact field type is set to sms:
image

then the sms contact info is clickable sms-link:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment