danjm
Follow
danjm
Follow
Pinned Loading
1,096 contributions in the last year
Less
More
Activity overview
Contributed to
MetaMask/metamask-extension,
MetaMask/eth-ledger-bridge-keyring,
MetaMask/metamask-filecoin-developer-beta
and 5 other
repositories
Loading
Contribution activity
November 2021
Created a pull request in MetaMask/metamask-extension that received 9 comments
Add support for eip-1559 on Trezor
Blocked by MetaMask/eth-trezor-keyring#107 and MetaMask/eth-trezor-keyring#108
+132
−41
•
9
comments
Opened 37 other pull requests in 6 repositories
MetaMask/metamask-extension
21
merged
4
open
1
closed
- Sync master with develop
- Sync develop with master
- Ensure that handleChange in token-input.component handles empty values
- Remove additional_removeBeforeUnload calls
- Adds multilayer fee display to erc20 token approval screen
- Bump @metmamask/logo to v3.1.1
- remove hiring link from readme
- Remove localhost from default network list
- Add fixed json-schema to resolutions file to resolve security issue
- Ensure one and only one localhost option appears in network list
- Ensure that metametrics error related to anonymousId is not sent to sentry
- Ensure the test network dismissal message in the network dropdown is permanently dismissed
- Simplify nickname scss
- Allow sending up to 18 decimals on the send screen
- Adding scroll bar to handle overflow of long network lists
- Ensure approve button can be enabled when using ledger webhid
- Add migration to set showTestNetworks to true if there is evidence of testnet use
- Fix copy issues related to layer 2 fee changes
- Activity log fix
- Support for Layer 2 networks with transaction fees on both layers
- Throw, and not just display, ledgerDeviceOpenFailureMessage error
- Fix flaky account removal e2e test
- Add Ledger connection flow warning message for failed to connect device error
- Ensure proper transport type is set before attempting to connect ledger wallet
- Ensure ledger transport preference is set on import
- Some pull requests not shown.
MetaMask/eth-trezor-keyring
4
merged
MetaMask/logo
2
merged
MetaMask/eth-token-tracker
1
open
1
merged
MetaMask/eth-ledger-bridge-keyring
2
merged
MetaMask/metamask-mobile
1
open
Reviewed 88 pull requests in 8 repositories
MetaMask/metamask-extension
77 pull requests
- Fix environment variables used during test builds
- Allow users to see confirm screen errors.
- Fix LavaMoat background policy generation
- Latest update conversion date - issue #10741
- Created a Nickname popover
- Ignore sentry server errors in e2e tests
- Convert token input to BigNumber to handle decimals better.
- Clear the clipboard after the seed phrase is pasted
- Fix: "BigNumber Error: times() number type has more than 15 significant digits"
- Introduce QR based signer into MetaMask
-
Sync
masterwithdevelop - Version v10.6.2 RC
-
Sync
masterwithdevelop - Fix issue where contractExchangeRates are not available in SwapsController
- Version v10.6.1 RC
- Add CollectiblesController & CollectibleDetectionController
-
Update
improved-yarn-auditand ignore 2 advisories - Don't dispatch hideTestNetMessage
- Create an "Add a Nickname" popover (also support edit) #12528
- display hex data on send screen fixed
- Updating changelog for v10.7.0
- Increase friction to bypass estimated revert
- Use v2 API for fiat onboarding URL creation, fix wrapping / unwrapping
- Adding edit gas fee modal
- Add support for eip-1559 on Trezor
- Some pull request reviews not shown.
MetaMask/eth-ledger-bridge-keyring
3 pull requests
MetaMask/eth-trezor-keyring
2 pull requests
MetaMask/test-dapp
2 pull requests
MetaMask/logo
1 pull request
MetaMask/metamask-mobile
1 pull request
MetaMask/controllers
1 pull request
MetaMask/eth-token-tracker
1 pull request
Created an issue in MetaMask/test-dapp that received 1 comment
Add buttons to deploy a contract that will always fail when sending a transaction to it
We need our test dapp to be able to test error cases. A basic error case that we need to add is a transaction with a smart contract, which will alw…
1
comment
Opened 6 other issues in 2 repositories
MetaMask/metamask-extension
1
closed
4
open
- Update 'Learn about scams and network security risks' link
- Warning not being shown when sending tokens to a known token contract address
-
Improve on error reporting from
waitForSelectore2e function - Fix display of hex data when in edit mode on send screen
- Refactor currency input component and ensure currency toggle persists between settings