The Wayback Machine - https://web.archive.org/web/20221001032408/https://github.com/a11yproject/a11yproject.com/issues/960
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Errors picked up by automated WAVE check - text contrast and empty link #960

Open
ActiveB1t opened this issue Jul 16, 2020 · 9 comments
Labels
accessibility Issues dealing with accessibility. bug Problems with the project's functionality good first issue A small, good place to get started working with the site. help wanted Issues the team would like assistince with.

Comments

@ActiveB1t
Copy link

ActiveB1t commented Jul 16, 2020

Summary

Running the WAVE plugin shows not all text has sufficient contrast, and an empty link is present, these are minor issues and potentially false positives, as the site may serve as an example for others it would be great if at least all errors from automated tests are resolved.

Expected result

Running a tool such as the WAVE plugin on Chrome shows no errors.

Actual result

The plugin shows not all text has sufficient contrast and an empty link is present.

Additional Information

  • The color #FB37FF is used on a #FFFFFF background on the homepage.
  • The color #0000EE is used on different background colors, this is potentially a false positive.
  • An empty link is present on the page https://www.a11yproject.com/resources/ above "Inclusive Design Patterns".
@ericwbailey ericwbailey added bug Problems with the project's functionality accessibility Issues dealing with accessibility. good first issue A small, good place to get started working with the site. help wanted Issues the team would like assistince with. labels Jul 17, 2020
@ericwbailey
Copy link
Member

ericwbailey commented Jul 22, 2020

Thanks for reporting this. We do have documentation around known issues and false positives, I'll continue to add to it as issues are uncovered.

While I agree with the sentiment of having no errors in a checker, I'm not sure we'd ever be able to get ahead of it. Some checkers will flag workarounds that others report. Some checkers like axe also flag things specifically because its unsure and needs manual review.

I think there's value to that. Especially with the idea that a perfect checker score does not mean "perfect accessibility." What do you think about the idea of a post covering the topic of false positives, and how to handle them? I am thinking it could be good guidance for people new to auditing, who may not be aware of the nuance.

@StommePoes
Copy link

StommePoes commented Dec 27, 2020

ping

I assume the flashing pink is not waiting for a PR but waiting to get past some huge behind-the-scenes fight over what accessible colour could replace the pink?

@ericwbailey
Copy link
Member

ericwbailey commented Dec 30, 2020

This is still definitely on my radar. I could take a shot at it, but do you have any opinions on palette modification, @tatianamac?

@navitux
Copy link

navitux commented Apr 6, 2022

Hi, Is this still open? I want contribute

@ericwbailey
Copy link
Member

ericwbailey commented Apr 7, 2022

@navitux We'd love the help!

@navitux
Copy link

navitux commented Apr 7, 2022

@navitux We'd love the help!

Hi, of course, sorry for the delay, I'm suddenly stuck with my current work, Could I check it after 17:00 CST today?? I'll give feedback as soon as possible

@ericwbailey
Copy link
Member

ericwbailey commented Apr 7, 2022

Absolutely no rush on our end. We'd much prefer people participate when they're in a safe and comfortable place to 🙂

@navitux
Copy link

navitux commented Apr 14, 2022

Hello, just to comment: I'm seeing that this WAVE (https://wave.webaim.org/) plugin does not detect errors in Chrome/Chromium but in Firefox it does, I think that is not needed a fix since: It seems Chrome oriented site and the "contrast" issue is not really noticeable and is currently uniformed colored comparing with all content in page

@SaptakS
Copy link
Member

SaptakS commented May 22, 2022

From #960 (comment)

It seems Chrome oriented site

I don't think that's the case and a11yproject is not speciically oriented for a particular browser. So even if it throws error in Firefox we should definitely fix.

From #960 (comment)

An empty link is present on the page https://www.a11yproject.com/resources/ above "Inclusive Design Patterns".

@ActiveB1t I can't find the empty link anymore. I tested both with WAVE (it doesn't seem to report for me either in firefox or chrome) and also manually I can't see any empty link in the source code. Maybe it got fixed while fixing some other stuff in website. Please let me know if you are still seeing the error.

As of the pink color, I think that's related to the discussions here: #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues dealing with accessibility. bug Problems with the project's functionality good first issue A small, good place to get started working with the site. help wanted Issues the team would like assistince with.
5 participants