New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Errors picked up by automated WAVE check - text contrast and empty link #960
Comments
|
Thanks for reporting this. We do have documentation around known issues and false positives, I'll continue to add to it as issues are uncovered. While I agree with the sentiment of having no errors in a checker, I'm not sure we'd ever be able to get ahead of it. Some checkers will flag workarounds that others report. Some checkers like axe also flag things specifically because its unsure and needs manual review. I think there's value to that. Especially with the idea that a perfect checker score does not mean "perfect accessibility." What do you think about the idea of a post covering the topic of false positives, and how to handle them? I am thinking it could be good guidance for people new to auditing, who may not be aware of the nuance. |
|
ping I assume the flashing pink is not waiting for a PR but waiting to get past some huge behind-the-scenes fight over what accessible colour could replace the pink? |
|
This is still definitely on my radar. I could take a shot at it, but do you have any opinions on palette modification, @tatianamac? |
|
Hi, Is this still open? I want contribute |
|
@navitux We'd love the help! |
Hi, of course, sorry for the delay, I'm suddenly stuck with my current work, Could I check it after 17:00 CST today?? I'll give feedback as soon as possible |
|
Absolutely no rush on our end. We'd much prefer people participate when they're in a safe and comfortable place to |
|
Hello, just to comment: I'm seeing that this WAVE (https://wave.webaim.org/) plugin does not detect errors in Chrome/Chromium but in Firefox it does, I think that is not needed a fix since: It seems Chrome oriented site and the "contrast" issue is not really noticeable and is currently uniformed colored comparing with all content in page |
|
From #960 (comment)
I don't think that's the case and a11yproject is not speciically oriented for a particular browser. So even if it throws error in Firefox we should definitely fix. From #960 (comment)
@ActiveB1t I can't find the empty link anymore. I tested both with WAVE (it doesn't seem to report for me either in firefox or chrome) and also manually I can't see any empty link in the source code. Maybe it got fixed while fixing some other stuff in website. Please let me know if you are still seeing the error. As of the pink color, I think that's related to the discussions here: #1008 |


ActiveB1t commentedJul 16, 2020
Summary
Running the WAVE plugin shows not all text has sufficient contrast, and an empty link is present, these are minor issues and potentially false positives, as the site may serve as an example for others it would be great if at least all errors from automated tests are resolved.
Expected result
Running a tool such as the WAVE plugin on Chrome shows no errors.
Actual result
The plugin shows not all text has sufficient contrast and an empty link is present.
Additional Information
The text was updated successfully, but these errors were encountered: