Move GitHub Connect reset to after ghe-config-apply #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, I discovered that the GitHub Connect reset logic I introduced in #770 fails when restoring a pre-3.0 snapshot to a 3.0 or later instance.
The reason for the failure is because the reset logic uses Rails functionality which comes with the assumption all migrations have happened and thus the database structure matches what the Rails code expects.
This PR fixes this by moving the GitHub Connect reset step to after
ghe-config-applyhas been run and this ensures all the migrations have run too./cc @domofactor