The Wayback Machine - https://web.archive.org/web/20211213212003/https://github.com/nodejs/node/pull/40915
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ping TSC members identified as inactive #40915

Merged
merged 3 commits into from Nov 24, 2021

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 21, 2021

When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

@Trott
Copy link
Member Author

@Trott Trott commented Nov 21, 2021

If we want to 100% make sure this works, we can fast-track it, close #40908, and let this open a PR.

@Trott Trott requested a review from targos Nov 21, 2021
.github/workflows/find-inactive-tsc.yml Outdated Show resolved Hide resolved
Loading
@targos
Copy link
Member

@targos targos commented Nov 22, 2021

This lgtm, but it was mostly the next part of the message that I was interested in automating:

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes.

@Trott
Copy link
Member Author

@Trott Trott commented Nov 24, 2021

This lgtm, but it was mostly the next part of the message that I was interested in automating:

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes.

OK, I think this does something like that now. (I haven't tested it via an Action yet, but will run it when it lands and revise if necessary.)

Trott added 2 commits Nov 24, 2021
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.
.github/workflows/find-inactive-tsc.yml Outdated Show resolved Hide resolved
Loading
targos
targos approved these changes Nov 24, 2021
@nodejs-github-bot nodejs-github-bot merged commit f7ac6ba into nodejs:master Nov 24, 2021
22 checks passed
Loading
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 24, 2021

Landed in f7ac6ba

@Trott Trott deleted the tsc-ping branch Nov 24, 2021
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 25, 2021

https://github.com/nodejs/node/runs/4315947355?check_suite_focus=true

Run gr2m/create-or-update-pull-request-action@v1
with:
    author: Node.js GitHub Bot <github-bot@iojs.org>
    branch: actions/inactive-tsc
    body: This PR was generated by tools/find-inactive-tsc.yml.
  
  @nodejs/tsc "@codebytere @gabrielschulhof"
  
  "Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes."
  
    commit-message: meta: move one or more TSC members to emeritus
    labels: meta
    title: meta: move one or more TSC members to emeritus
  env:
    NODE_VERSION: lts/*
    INACTIVE_TSC_HANDLES: "@codebytere @gabrielschulhof"
    DETAILS_FOR_COMMIT_BODY: "Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes."

The only nit would be to get rid of the " (maybe using fromJSON? not sure); other than that, LGTM.

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2021

The only nit would be to get rid of the " (maybe using fromJSON? not sure); other than that, LGTM.

I wonder if spaces aren't a problem in single-line GITHUB_ENV entries and we can just remove the quotation marks there.

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 25, 2021

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2021

And if all else fails, we can use the multi-line HEREDOC format they support which doesn't require quotation marks or other punctuation around spaces.

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2021

(Testing now on my fork.)

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2021

Yup, leaving out the quotation marks worked. https://github.com/Trott/io.js/runs/4318829465?check_suite_focus=true (The failure is because I didn't set a needed token on my fork.)

PR coming momentarily.

nodejs-github-bot pushed a commit that referenced this issue Nov 25, 2021
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this issue Nov 26, 2021
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

PR-URL: #40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos added a commit that referenced this issue Nov 26, 2021
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment