The Wayback Machine - https://web.archive.org/web/20201213051048/https://github.com/crev-dev/cargo-crev/issues/138
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`crev review` to take `--rating=`, `--understanding=` and `--thoroughness=`. #138

Open
dpc opened this issue Jan 7, 2019 · 2 comments
Open

Comments

@dpc
Copy link
Collaborator

@dpc dpc commented Jan 7, 2019

This is to help people that for whatever reason don't want to go through the effort of changing it manually every time.

Default levels of understanding and thoroughness for both positive (review)and negative(flag) could also be configurable in the user-config file.

@jonas-schievink
Copy link

@jonas-schievink jonas-schievink commented Jan 12, 2019

Is a default value for those really desirable? It seems pretty unrealistic to expect most reviews to end up with the same level of understanding, so I think I'd prefer to be forced to specify it explicitly.

@dpc
Copy link
Collaborator Author

@dpc dpc commented Jul 24, 2019

That's a good point. Then again, there are legitimate reasons for this. Maybe someone is writing a bot or something and they always want --understanding=none... . I feel like only users that really, really need it will go through the hasle of typing on the console, or writing a wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.