This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
[Bug] Recent searches layout issues #22445
Assignees
Labels
Feature:History
Feature:HomeScreen
Feature:SearchGroupHistory
Search term groups on History view
good first issue
Good for newcomers
Milestone
Comments
Mugurell
added
Feature:History
Feature:HomeScreen
Feature:SearchGroupHistory
amedyne
added
good first issue
|
@topotropic Seeing that this issues will only get worse with the addition of history highlights - there will definetly be more pages of "recent visits" to display now I was wondering if this section could have the same behavior as the Pocket articles - snap to the next page instead of scrolling to any position which can easily lead to strange situations. The issue with the menu will then easily be solvable (if not automatically solved) and the only other needed change would be making sure that the group dividers also show - they are set to show but for some reason they don't. |
|
Yes, we can follow the same snapping behavior that Pocket has. Thanks! |
Mugurell
added this to Ready for Engineering (min-5 ; max-22)
in Android Engineering Team Kanban board
via automation
Mugurell
moved this from Ready for Engineering (min-5 ; max-22)
to In Development (WIP limit - 15)
in Android Engineering Team Kanban board
Mugurell
moved this from In Development (WIP limit - 15)
to Dev Complete (WIP limit - 5)
in Android Engineering Team Kanban board
gabrielluong
moved this from Dev Complete (WIP limit - 5)
to Reviewer approved, ready for test (WIP limit - ?)
in Android Engineering Team Kanban board
3 tasks
Android Engineering Team Kanban board
automation
moved this from Reviewer approved, ready for test (WIP limit - ?)
to Done
Dec 7, 2021
mergify bot
pushed a commit
that referenced
this issue
Dec 7, 2021
One important issue was that the items are smaller that the width of the screen and so a bit of the next column would be showing also and user could interact with this only peaking items and a long press would open a dropdown menu with no place to anchor it. To mitigate this: - the items will now snap to the next position when scrolling so that we'll always show at least one column in it's entirety. - menus are enabled only if more than half of the item is visible effectively disabling clicks on that peaking area of neighbour columns. This patch also updates the divider for history groups which previously wasn't showing.
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 8, 2022
…y visited One important issue was that the items are smaller that the width of the screen and so a bit of the next column would be showing also and user could interact with this only peaking items and a long press would open a dropdown menu with no place to anchor it. To mitigate this: - the items will now snap to the next position when scrolling so that we'll always show at least one column in it's entirety. - menus are enabled only if more than half of the item is visible effectively disabling clicks on that peaking area of neighbour columns. This patch also updates the divider for history groups which previously wasn't showing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The recent searches layout is horizontally scrollable but when scrolled the items have a different layout and the menu is not properly anchored.
Another issue is that the divider is not showing.
cc @gabrielluong @topotropic
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: