The Wayback Machine - https://web.archive.org/web/20211118005011/https://github.com/arduino/arduino-cli/pull/1549
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now compile --only-compilation-database will run all pre-* hooks #1549

Merged
merged 8 commits into from Nov 17, 2021
Merged

Now compile --only-compilation-database will run all pre-* hooks #1549

merged 8 commits into from Nov 17, 2021

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 16, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    To generate the "Compilation Database" some platforms requires to run the pre-build hooks to actually have a compilable target.
  • What is the current behavior?
    The pre-hooks are skipped.
  • What is the new behavior?
    The pre-hooks are now executed.
  • Does this PR introduce a breaking change, and is titled accordingly?
    It may introduce some regression if a platform requires skipping pre-hooks to actually build a sketch. This is very unlikely BTW, since this would make fail also the full compile.
  • Other information:
    The post hooks and the compiler commands are still SKIPPED.

Fix #1547
@cmaglie cmaglie requested review from per1234 and Nov 16, 2021
@cmaglie cmaglie force-pushed the fix-compile-db branch from c64ab27 to 88584e5 Nov 16, 2021
@cmaglie cmaglie changed the title Now 'compile --only-compilation-database' will run all pre-* hooks Now compile --only-compilation-database will run all pre-* hooks Nov 16, 2021
@cmaglie cmaglie self-assigned this Nov 16, 2021
@cmaglie cmaglie force-pushed the fix-compile-db branch from 88584e5 to bc4f7aa Nov 16, 2021
umbynos
umbynos reviewed Nov 16, 2021
View changes
test/test_compile_part_4.py Show resolved Hide resolved
Loading
per1234
per1234 requested changes Nov 16, 2021
View changes
cli/compile/compile.go Outdated Show resolved Hide resolved
Loading
docs/platform-specification.md Outdated Show resolved Hide resolved
Loading
test/test_compile_part_4.py Outdated Show resolved Hide resolved
Loading
test/test_compile_part_4.py Outdated Show resolved Hide resolved
Loading
per1234
per1234 approved these changes Nov 16, 2021
View changes
Copy link
Contributor

@per1234 per1234 left a comment

I'm not knowledgeable about the compilation database subject, but I was able to reproduce #1547 for both esp32:esp32 and STMicroelectronics:stm32 boards platforms previously and am not able to reproduce it after the change proposed here.
@cmaglie cmaglie merged commit e72f683 into arduino:master Nov 17, 2021
111 checks passed
Loading
@cmaglie cmaglie deleted the fix-compile-db branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@cmaglie @per1234 @umbynos